Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove java owlbot #2013

Merged
merged 3 commits into from
Sep 24, 2024
Merged

chore: remove java owlbot #2013

merged 3 commits into from
Sep 24, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Sep 20, 2024 •
edited
Loading

In this PR:

  • Rmove Java Owlbot since the source code is migrated to sdk-platform-java and it is disabled in non-GAPIC libraries (see go/disable-owlbot-java).

This was referenced Sep 20, 2024
Closed
Merged
@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 23, 2024 16:15
@JoeWang1127 JoeWang1127 requested review from a team and chingor13 as code owners September 23, 2024 16:15
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 23, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

blakeli0
blakeli0 reviewed Sep 23, 2024
View reviewed changes
tests/test_language_java.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this test being migrated to sdk-platform-java and looks like it still provides value, can you try to move it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traced in googleapis/sdk-platform-java#3227

docker/owlbot/java/cloudbuild.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there are some cloud build triggers associated with these cloud build yamls? Can we figure out what are them and delete them as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created b/368584265 so @chingor13 can remove it.

@JoeWang1127 JoeWang1127 merged commit cfbee34 into master Sep 24, 2024
10 of 11 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/remove-java-owlbot branch September 24, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @chingor13 @blakeli0