Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve the README template #208

Merged
merged 2 commits into from
Mar 27, 2019
Merged

chore: improve the README template #208

merged 2 commits into from
Mar 27, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 27, 2019

organically @callmehiphop has made some great edits to README.md. This modifies our base template to make it lineup.

Now all our libraries can move towards this straight-forward standard.

@bcoe bcoe requested a review from callmehiphop March 27, 2019 01:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2019
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but lets not call Dave out in the commit history :) Maybe just 'chore: improve the README template'?

@callmehiphop
Copy link
Contributor

lets not call Dave out in the commit history

hater!

@bcoe bcoe changed the title chore: get template in alignment with Dave's manual work chore: improve the README template Mar 27, 2019
@bcoe bcoe merged commit de9451b into master Mar 27, 2019
@bcoe bcoe deleted the tweaks branch March 27, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants