feat: also generate samples/README.md #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
commented
Mar 27, 2019
synthtool/gcp/common.py
Outdated
| @@ -57,6 +57,7 @@ def node_library(self, **kwargs) -> Path: | |||
| # .repo-metadata.json, or excluding README.md, we can remove this. | |||
| if not os.path.exists("./.repo-metadata.json"): | |||
| self.excludes.append("README.md") | |||
| self.excludes.append("samples/README.md") | |||
There was a problem hiding this comment.
we don't want to generate the new README until we've plopped a .repo-metadata.json in the folder, otherwise we get a junk file.
| * [{{ sample.name }}](#{{ sample.name|slugify }}){% endfor %}{% endif %} | ||
|
|
||
| ## Before you begin | ||
|
|
There was a problem hiding this comment.
this README has been simplified, the need for executing samples to generate yargs output, this matches the direction we're moving in for samples any ways.
JustinBeckwith
approved these changes
Mar 27, 2019
| @@ -0,0 +1,51 @@ | |||
| [//]: # "This README.md file is auto-generated, all changes to this file will be lost." | |||
| [//]: # "To regenerate it, use `npm run generate-scaffolding`." | |||
There was a problem hiding this comment.
Don't think we want npm run generate-scaffolding
busunkim96
reviewed
Mar 27, 2019
3 tasks
Co-Authored-By: bcoe <bencoe@google.com>
busunkim96
reviewed
Mar 28, 2019
busunkim96
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to the work with
./README.md,synthtoolwill now regeneratesamples/README.mdas changes are made to the samples directory.