Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: removes unused kokoro config files #692

Merged

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Jul 24, 2020

Removes unused kokoro files from the java library template. We have stopped running some of these due to Github quota issues.
These changes have been manually applied in the java spanner repository. From previous conversations it was understood that these changes should be applied to the template repository as well. If this is not the case, feel free to reject the PR.

Removes unused kokoro files from the java library template. We have
stopped running some of these due to Github quota issues.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle marked this pull request as draft July 24, 2020 18:27
@SurferJeffAtGoogle
Copy link
Contributor

I marked this PR as a draft until I fix Autosynth so it will actually delete the files in repos.

@thiagotnunes
Copy link
Contributor Author

@SurferJeffAtGoogle no worries, thanks @SurferJeffAtGoogle !

@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle marked this pull request as ready for review August 5, 2020 18:19
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep the nightly/samples.cfg and presubmit/samples.cfg. Otherwise, we have the file tracking in place so we can delete the files this way.

thiagotnunes and others added 3 commits August 6, 2020 09:28
The files presubmit/samples.cfg and nightly/samples.cfg should remain in
the java template repository.
@thiagotnunes
Copy link
Contributor Author

thiagotnunes commented Aug 5, 2020

@chingor13 I put back the files presubmit/samples.cfg and nightly/samples.cfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants