Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommend installation via pip -e #693

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

busunkim96
Copy link
Contributor

Closes #691

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2020

```
cd synthtool
export PYTHONPATH=`pwd`
python3 -m pip install -e .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier versions of this file had the exact same command, but the command failed for Justin Beckwith.

So line 19 looks good, but line 23 doesn't work for all users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinBeckwith Do you remember how this failed for you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh, this was a while ago now, and I can't remember what was failing. What I do remember is that when installing directly from the repository, synthtool --version became practically useless. I was struggling to get the right version of synthtool on my path, and doing a --version would always tell me the same version regardless of which commit I had installed against.

I'd like to arrive at one of two places here. Either:

  • We update synthtool --version to include the sha at which it's running alongside the current version or
  • We arrive at a place where we're consistently releasing every time after updates are made

@busunkim96 busunkim96 closed this Jul 31, 2020
@busunkim96 busunkim96 reopened this Jul 31, 2020
@SurferJeffAtGoogle
Copy link
Contributor

Actually, Justin's difficulty was running autosynth, not synthtool, so I'm ok with this change.

@SurferJeffAtGoogle SurferJeffAtGoogle merged commit 8f64979 into master Aug 5, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle deleted the busunkim96-patch-4 branch August 5, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lost installation documentation
3 participants