Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make synthtool an executable #74

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Make synthtool an executable #74

merged 2 commits into from
Sep 19, 2018

Conversation

busunkim96
Copy link
Contributor

See #32

busunkim-macbookpro1:automl busunkim$ synthtool --version
0.8.0
busunkim-macbookpro1:automl busunkim$ synthtool
synthtool > Executing /Users/busunkim/GCP/google-cloud-python/automl/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Cloning googleapis.

theacodes
theacodes suggested changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (almost) good to me.

synthtool/main.py Outdated
@@ -0,0 +1,21 @@
import importlib

This comment was marked as spam.

Sign in to view

@busunkim96
Copy link
Contributor Author

PTAL

@theacodes theacodes merged commit d2d2ba0 into googleapis:master Sep 19, 2018
@busunkim96 busunkim96 deleted the make-executable branch September 19, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busunkim96 @theacodes