Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): use 'setup.py' to detect repo root #795

Merged
merged 1 commit into from
Oct 9, 2020
Merged

chore(python): use 'setup.py' to detect repo root #795

merged 1 commit into from
Oct 9, 2020

Conversation

busunkim96
Copy link
Contributor

Closes #792

@busunkim96 busunkim96 requested a review from a team as a code owner October 9, 2020 20:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2020
anguillanneuf
anguillanneuf approved these changes Oct 9, 2020
View reviewed changes
Copy link

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work! Thanks!

@busunkim96 busunkim96 merged commit e0ae456 into master Oct 9, 2020
@busunkim96 busunkim96 deleted the busunkim96-patch-8 branch October 9, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_get_repo_root() in noxfile.py can fail when .git does not exist at project root
2 participants
@busunkim96 @anguillanneuf