-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discogapic generator #90
Conversation
I opted for a separate module rather than trying overload the other gapic generator. An alternative would be to add another option to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little concerned about the now duplicated code, especially the low-level stuff around invoking docker and figuring out the config file. Can you work with @busunkim96 to factor that out?
@theacodes @busunkim96 offered to do the refactor and should be able to push directly here. |
Looks like the |
Java Compute uses a discogapic generator (the a gapic generator that accepts discovery docs rather than protos). This adds a new generator that fetches the discovery-artifact-manager repo.
The java compute synth would end up like: