Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add graphviz to container image #31

Merged
merged 4 commits into from
Sep 17, 2019
Merged

node: add graphviz to container image #31

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c21cbba
node: add graphviz
grayside Sep 4, 2019
3a4c55f
Merge branch 'master' into node/graphviz
grayside Sep 12, 2019
74f0a59
Merge branch 'master' into node/graphviz
bcoe Sep 12, 2019
5a41bc0
Merge branch 'master' into node/graphviz
bcoe Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions node/10-user/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@

FROM node:10-stretch

# Add Graphviz
RUN set -ex; \
apt-get update -y; \
apt-get install -y \
graphviz \
; \
rm -rf /var/lib/apt/lists/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to delete the package information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is standard practice in Dockerfiles to clean up package information/caches related to packager tooling to create lean images. This is the standard approach recommended with apt-get.


USER node

RUN curl -L https://github.com/pyenv/pyenv-installer/raw/master/bin/pyenv-installer | bash
Expand Down
8 changes: 8 additions & 0 deletions node/11-user/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@

FROM node:11-stretch

# Add Graphviz
RUN set -ex; \
apt-get update -y; \
apt-get install -y \
graphviz \
; \
rm -rf /var/lib/apt/lists/*

USER node

RUN curl -L https://github.com/pyenv/pyenv-installer/raw/master/bin/pyenv-installer | bash
Expand Down
8 changes: 8 additions & 0 deletions node/12-user/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@

FROM node:12-stretch

# Add Graphviz
RUN set -ex; \
apt-get update -y; \
apt-get install -y \
graphviz \
; \
rm -rf /var/lib/apt/lists/*

USER node

RUN curl -L https://github.com/pyenv/pyenv-installer/raw/master/bin/pyenv-installer | bash
Expand Down