This repository has been archived by the owner on Nov 5, 2022. It is now read-only.
Update list of enforced lints #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nshahan
commented
Feb 17, 2021
nshahan
commented
- Bump version number.
- Update README with considered but unused lints.
pq
reviewed
Feb 17, 2021
| - [`unnecessary_brace_in_string_interps`] | ||
| - [`unnecessary_getters_setters`] | ||
| - [`use_full_hex_values_for_flutter_colors`] | ||
| - [`unsafe_html`] |
There was a problem hiding this comment.
consider sorting unsafe_html before use_full_hex_values_for_flutter_colors?
CHANGELOG.md
Outdated
| [`use_full_hex_values_for_flutter_colors`]: https://dart-lang.github.io/linter/lints/use_full_hex_values_for_flutter_colors.html | ||
| [`unsafe_html`]: https://dart-lang.github.io/linter/lints/unsafe_html.html | ||
| [`avoid_empty_else`]: https://dart-lang.github.io/linter/lints/avoid_empty_else.html | ||
| [`curly_braces_in_control_structures`]: https://dart-lang.github.io/linter/lints/curly_braces_in_flow_control_structures.html |
| @@ -143,7 +146,7 @@ on web code only. | |||
| is too strict, it's okay to `print` in some code. | |||
|
|
|||
| `avoid_returning_null` | |||
| will be obsoleted by NNBD. | |||
| will be obsoleted by sound null safety. | |||
davidmorgan
reviewed
Feb 18, 2021
README.md
Outdated
| will be obsoleted by NNBD, which comes with type inference for uninitialized | ||
| variables. | ||
| will be obsoleted by sound null safety, which comes with type inference for | ||
| uninitialized variables. |
There was a problem hiding this comment.
This turned out to be wrong!... please remove from the banned list :)
davidmorgan
reviewed
Feb 18, 2021
|
@davidmorgan I just realized I forgot to update the package version in the pubspec.yaml. Just want to leave you a note here that I pushed that change after your review. |
|
Awesome, thanks :) publishing... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.