This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Don't use is="" with custom-style #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
approved these changes
Sep 26, 2016
| const customStyle = | ||
| parse5.treeAdapters.default.createElement('custom-style', '', []); | ||
| dom5.insertBefore(parent, style, customStyle); | ||
| dom5.remove(style); |
There was a problem hiding this comment.
remove shouldn't be necessary if you only append via dom5
| dom5.setAttribute(customStyle, 'include', include); | ||
| dom5.removeAttribute(style, 'include'); | ||
| } | ||
| customStyle.childNodes = customStyle.childNodes || []; |
There was a problem hiding this comment.
append() should work with no childNodes with dom5 2.0.0, and it'll correctly remove the element from existing parents.
rictic
force-pushed
the
custom-style-no-is
branch
from
0861540
to
a5ec2ac
Compare
rictic
force-pushed
the
custom-style-no-is
branch
from
a5ec2ac
to
2db6e47
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.