Merge pull request #91 from GoogleChrome/gulp-reject-with-message

Add a rejection value to our promise-spawn-wrapper error handling
googlearchive · Jul 31, 2017 · eed46b0 · eed46b0
2 parents fc39d11 + f594b14
commit eed46b0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/gulp-tasks/jekyll.js b/gulp-tasks/jekyll.js
@@ -44,7 +44,7 @@ const runJekyllCommand = (command, additionalParams) => {
       if (code === 0) {
         resolve();
       } else {
-        reject();
+        reject(`Error ${code} returned from: jekyll ${params.join(' ')}`);
       }
     });
   });

diff --git a/gulp-tasks/reference-docs.js b/gulp-tasks/reference-docs.js
@@ -21,13 +21,14 @@ const downloadTaggedRelease = (tagName) => {
 
   const docPath = path.join(TMP_PATH, tagName);
   return new Promise((resolve, reject) => {
-    const gitDownload = spawn('git', [
+    const params = [
       'clone',
       '--branch', tagName,
       '--depth', '1',
       `http://${GIT_REPO}.git`,
       docPath,
-    ], {
+    ];
+    const gitDownload = spawn('git', params, {
       stdio: 'inherit',
     });
 
@@ -40,7 +41,7 @@ const downloadTaggedRelease = (tagName) => {
       if (code === 0) {
         resolve(docPath);
       } else {
-        reject();
+        reject(`Error ${code} returned from: git ${params.join(' ')}`);
       }
     });
   });