Fix for runtimeCaching plugin config conversion #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Feb 28, 2018
| switch (pluginName) { | ||
| // Special case logic for plugins that have a required parameter, and then | ||
| // an additional optional config parameter. | ||
| case 'backgroundSync': { |
There was a problem hiding this comment.
I was thinking of combining this and the next case, which would prevent some code duplication. One reads the required value from the name parameter, and the other reads it from channelName, though, so there would be some extra logic that would need to be added.
I ended up keeping them separate, but if folks would prefer them combined, I could do that.
There was a problem hiding this comment.
I think seperate makes sense - makes the tests super easy to read.
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 155% of our max size budget. Total Size: 22.7KB Gzipped: 9.1KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
Fixes #1334
With additional tests as well.