build_name_table: Set stylename to no longer reflect the font's origin master #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to close this since Ms Word font Menu styles are created using nameID 1/16 (family names) + fvar instance subfamily names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vv-monsalve has been testing variable fonts in Windows MS Word and she's noticed that our current VF name table are causing some issues. These issues have been reported in several threads, most notably fonttools/fontbakery#2179.
Currently, our variable font name tables reflect the origin master of the font. I still maintain this is technically correct and follows the spec. However, Adobe's Source Sans doesn't do this and it seems to work better in MS Word so I've adopted the Adobe approach for now. Dave C, Chris, Viviana have all agreed this approach works better.