Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary script: Zinh automatically added #708

Closed
emmamarichal opened this issue Aug 31, 2023 · 8 comments · Fixed by #714
Closed

Primary script: Zinh automatically added #708

emmamarichal opened this issue Aug 31, 2023 · 8 comments · Fixed by #714
Labels
packager Issues related to gftools-packager

Comments

@emmamarichal
Copy link
Contributor

Hello,

When I use gftools packager, a "primary_script: Zinh" is automatically added in metadata.pb
any idea?

thanks!
@emmamarichal emmamarichal added the packager Issues related to gftools-packager label Aug 31, 2023
@simoncozens
Copy link
Contributor

Can you point me at a font where this happens, or is it all of them?

@emmamarichal
Copy link
Contributor Author

It happened in my last PRs, so since end of July I would say
-google/fonts#6651
-google/fonts#6561
-google/fonts#6585

@simoncozens
Copy link
Contributor

Weird, I don't see that, but I do see the "empty sample text"!

@simoncozens
Copy link
Contributor

OK, got it; fixing...

simoncozens added a commit that referenced this issue Sep 1, 2023
@simoncozens
Don’t report Z... as a primary script, fixes #708
e4749e9
@simoncozens simoncozens mentioned this issue Sep 1, 2023
Merged
@emmamarichal
Copy link
Contributor Author

great, thank you!

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Sep 7, 2023 •
edited
Loading

This auto addition for "Zinh" is still happening

@simoncozens
Copy link
Contributor

I think updating your local gftools-packager will fix it.

@vv-monsalve
Copy link
Contributor

Right! It works with v 0.9.34. Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packager Issues related to gftools-packager
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don’t report Z... as a primary script googlefonts/gftools
3 participants
@simoncozens @vv-monsalve @emmamarichal