Gftools packager: several issues #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphicore
changed the title
…t in METADATA.pb; fixes googlefonts#233
graphicore
force-pushed
the
gftools-packager
branch
from
350825e to
aa65af8
Compare
m4rc1e
requested changes
Sep 3, 2020
m4rc1e
reviewed
Sep 3, 2020
m4rc1e
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #238: trying to fix wrongly selected remote for PR
Fixes an issue that happened to me when testing this, unlikely in normal usage though
I don't know if
_pygit2.GitError: unsupported URL protocolis fixed with this!UPDATE:
also fix #233 remove redundant info from upstream.yaml, remove comments from upstream.yaml