-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
com.schriftgestaltung.useNiceNames should be boolean #247
Comments
@anthrotype @moyogo I will add this in #235 |
belluzj
added a commit
to belluzj/glyphsLib
that referenced
this issue
Oct 20, 2017
@belluzj Thanks for looking at this quickly. Noticed in your fix, it also needs to covert disablesLastchange to boolean. |
Thanks; actually it was included in the fix, because I added the field name to the list of "_CUSTOM_BOOL_PARAMS", but I added a test nonetheless. That's one more test :) |
Great - sorry I missed the custom bool params when I looked at the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
com.schriftgestaltung.useNiceNames should be a boolean value in the UFO rather than integer.
So, in ufo.py, this section needs updating:
Also, for that section, Glyphs key "Disable Last Change" should be added to map to com.schriftgestaltung.disablesLastChange, and this also should be boolean in the UFO
The text was updated successfully, but these errors were encountered: