calcCodePageRanges: always enable at least bit 0 (Latin 1)

Fixes googlefonts/fontmake#468
googlefonts · Oct 8, 2018 · 15aada1 · 15aada1
1 parent c9925b3
commit 15aada1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/Lib/ufo2ft/util.py b/Lib/ufo2ft/util.py
@@ -262,6 +262,12 @@ def calcCodePageRanges(unicodes):
     if hasAscii and "‰" in chars and "∑" in chars:
         codepageRanges.add(29)              # Macintosh Character Set (US Roman)
 
+    # when no codepage ranges can be enabled, fall back to enabling bit 0
+    #(Latin 1) so that the font works in MS Word:
+    # https://github.com/googlei18n/fontmake/issues/468
+    if not codepageRanges:
+        codepageRanges.add(0)
+
     return codepageRanges
 
 

diff --git a/tests/outlineCompiler_test.py b/tests/outlineCompiler_test.py
@@ -753,6 +753,7 @@ def test_too_long_production_name(self, testufo):
         [ASCII + ["┤", "√", "é"], {52}],  # MS-DOS Canadian French
         [ASCII + ["┤", "√", "õ"], {55}],  # MS-DOS Portuguese
         [ASCII + ["‰", "∑"], {29}],  # Macintosh Character Set (US Roman)
+        [[" ", "0", "1", "2", "අ"], {0}],  # always fallback to Latin 1
     ],
 )
 def test_calcCodePageRanges(emptyufo, unicodes, expected):