applied review notes

googleforgames · Feb 25, 2020 · 019ee92 · 019ee92
1 parent 5d65b31
commit 019ee92
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/build/includes/minikube.mk b/build/includes/minikube.mk
@@ -54,10 +54,6 @@ minikube-push: minikube-agones-profile
 	$(MAKE) minikube-transfer-image TAG=$(ping_tag)
 	$(MAKE) minikube-transfer-image TAG=$(allocator_tag)
 
-minikube-push-simple-udp: minikube-agones-profile
-	$(MAKE) minikube-transfer-image TAG=gcr.io/agones-images/udp-server:0.18
-
-
 # Installs the current development version of Agones into the Kubernetes cluster.
 # Use this instead of `make install`, as it disables PullAlways on the install.yaml
 minikube-install: minikube-agones-profile

diff --git a/site/content/en/docs/Guides/local-game-server.md b/site/content/en/docs/Guides/local-game-server.md
@@ -32,7 +32,7 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image: gcr.io/agones-images/udp-server:0.17
+        image: gcr.io/agones-images/udp-server:0.18
 ```
 
 Once you save this to a file make sure you have `kubectl` configured to point to your Agones cluster and then run `kubectl apply -f dev-gameserver.yaml`. This will register your server with Agones.

diff --git a/site/content/en/docs/Guides/troubleshooting.md b/site/content/en/docs/Guides/troubleshooting.md
@@ -51,7 +51,7 @@ Spec:
       Creation Timestamp:  <nil>
     Spec:
       Containers:
-        Image:  gcr.io/agones-images/udp-server:0.17
+        Image:  gcr.io/agones-images/udp-server:0.18
         Name:   simple-udp
         Resources:
           Limits:
@@ -82,7 +82,7 @@ Events:
 The backing Pod has the same name as the `GameServer` - so it's also worth looking at the
 details and events for the Pod to see if there are any issues there, such as restarts due to binary crashes etc.
 
-For example, you can see the restart count on the gcr.io/agones-images/udp-server:0.17 container
+For example, you can see the restart count on the gcr.io/agones-images/udp-server:0.18 container
 is set to `1`, due to the game server binary crash
 
 ```
@@ -104,7 +104,7 @@ Controlled By:      GameServer/simple-udp-zqppv
 Containers:
   simple-udp:
     Container ID:   docker://69eacd03cc89b0636b78abe47926b02183ba84d18fa20649ca443f5232511661
-    Image:          gcr.io/agones-images/udp-server:0.17
+    Image:          gcr.io/agones-images/udp-server:0.18
     Image ID:       docker-pullable://gcr.io/agones-images/udp-server@sha256:6a60eff5e68b88b5ce75ae98082d79cff36cda411a090f3495760e5c3b6c3575
     Port:           7654/UDP
     Host Port:      7058/UDP
@@ -173,7 +173,7 @@ Events:
   Normal  Created    2m28s                 kubelet, gke-test-cluster-default-590db5e4-4s6r  Created container
   Normal  Created    114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Created container
   Normal  Started    114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Started container
-  Normal  Pulled     114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Container image "gcr.io/agones-images/udp-server:0.17" already present on machine
+  Normal  Pulled     114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Container image "gcr.io/agones-images/udp-server:0.18" already present on machine
 ```
 
 Finally, you can also get the logs of your `GameServer` `Pod` as well via `kubectl logs <pod name> -c <game server container name>`, for example:

diff --git a/test/e2e/framework/framework.go b/test/e2e/framework/framework.go
@@ -92,8 +92,8 @@ func NewFromFlags() (*Framework, error) {
 	usr, _ := user.Current()
 	kubeconfig := flag.String("kubeconfig", filepath.Join(usr.HomeDir, "/.kube/config"),
 		"kube config path, e.g. $HOME/.kube/config")
-	gsimage := flag.String("gameserver-image", "gcr.io/agones-images/udp-server:0.17",
-		"gameserver image to use for those tests, gcr.io/agones-images/udp-server:0.17")
+	gsimage := flag.String("gameserver-image", "gcr.io/agones-images/udp-server:0.18",
+		"gameserver image to use for those tests, gcr.io/agones-images/udp-server:0.18")
 	pullSecret := flag.String("pullsecret", "",
 		"optional secret to be used for pulling the gameserver and/or Agones SDK sidecar images")
 	stressTestLevel := flag.Int("stress", 0, "enable stress test at given level 0-100")