Added more tests

TestControllerCreationMutationHandler, TestControllerCreationValidationHandler, TestControllerUpsertGameServerSet more tests more tests review notes
googleforgames · Jun 2, 2020 · 0932d24 · 0932d24
1 parent 91dbe07
commit 0932d24
Show file tree

Hide file tree

Showing 2 changed files with 395 additions and 98 deletions.
diff --git a/pkg/fleets/controller.go b/pkg/fleets/controller.go
@@ -408,10 +408,10 @@ func (c *Controller) recreateDeployment(fleet *agonesv1.Fleet, rest []*agonesv1.
 func (c *Controller) rollingUpdateDeployment(fleet *agonesv1.Fleet, active *agonesv1.GameServerSet, rest []*agonesv1.GameServerSet) (int32, error) {
 	replicas, err := c.rollingUpdateActive(fleet, active, rest)
 	if err != nil {
-		return replicas, err
+		return 0, err
 	}
 	if err := c.rollingUpdateRest(fleet, rest); err != nil {
-		return replicas, err
+		return 0, err
 	}
 	return replicas, nil
 }
@@ -437,7 +437,7 @@ func (c *Controller) rollingUpdateActive(fleet *agonesv1.Fleet, active *agonesv1
 
 	r, err := intstr.GetValueFromIntOrPercent(fleet.Spec.Strategy.RollingUpdate.MaxSurge, int(fleet.Spec.Replicas), true)
 	if err != nil {
-		return replicas, errors.Wrapf(err, "error calculating scaling gameserverset: %s", fleet.ObjectMeta.Name)
+		return 0, errors.Wrapf(err, "error calculating scaling gameserverset: %s", fleet.ObjectMeta.Name)
 	}
 	surge := int32(r)