Skip to content

Commit

Permalink
Switch to using default gke-cluster oauthScopes
Browse files Browse the repository at this point in the history
Verified that we can change oauthScope nodePool settings to
gke-defaults. Tests test-e2e, metrics and logs works as before.
  • Loading branch information
aLekSer authored and markmandel committed Mar 4, 2019
1 parent 9bc422d commit 0b9af68
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
4 changes: 3 additions & 1 deletion build/gke-test-cluster/cluster-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ resources:
tags:
- game-server
oauthScopes:
- https://www.googleapis.com/auth/compute
- https://www.googleapis.com/auth/devstorage.read_only
- https://www.googleapis.com/auth/logging.write
- https://www.googleapis.com/auth/monitoring
- https://www.googleapis.com/auth/service.management.readonly
- https://www.googleapis.com/auth/servicecontrol
- https://www.googleapis.com/auth/trace.append
- name: game-server-firewall
type: compute.beta.firewall
properties:
Expand Down
12 changes: 9 additions & 3 deletions build/gke-test-cluster/cluster.yml.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,23 @@ resources:
tags:
- game-server
oauthScopes:
- https://www.googleapis.com/auth/compute
- https://www.googleapis.com/auth/devstorage.read_only
- https://www.googleapis.com/auth/logging.write
- https://www.googleapis.com/auth/monitoring
- https://www.googleapis.com/auth/service.management.readonly
- https://www.googleapis.com/auth/servicecontrol
- https://www.googleapis.com/auth/trace.append
- name: "agones-system"
initialNodeCount: 1
config:
machineType: n1-standard-4
oauthScopes:
- https://www.googleapis.com/auth/compute
- https://www.googleapis.com/auth/devstorage.read_only
- https://www.googleapis.com/auth/logging.write
- https://www.googleapis.com/auth/monitoring
- https://www.googleapis.com/auth/service.management.readonly
- https://www.googleapis.com/auth/servicecontrol
- https://www.googleapis.com/auth/trace.append
labels:
stable.agones.dev/agones-system: "true"
taints:
Expand All @@ -54,10 +58,12 @@ resources:
config:
machineType: n1-standard-4
oauthScopes:
- https://www.googleapis.com/auth/compute
- https://www.googleapis.com/auth/devstorage.read_only
- https://www.googleapis.com/auth/logging.write
- https://www.googleapis.com/auth/monitoring
- https://www.googleapis.com/auth/service.management.readonly
- https://www.googleapis.com/auth/servicecontrol
- https://www.googleapis.com/auth/trace.append
labels:
stable.agones.dev/agones-metrics: "true"
taints:
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/docs/Installation/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ gcloud container clusters create [CLUSTER_NAME] --cluster-version=1.11 \
--tags=game-server \
--enable-basic-auth \
--password=supersecretpassword \
--scopes=https://www.googleapis.com/auth/devstorage.read_only,compute-rw,cloud-platform \
--scopes=gke-default \
--num-nodes=3 \
--machine-type=n1-standard-1
```
Expand Down

0 comments on commit 0b9af68

Please sign in to comment.