Skip to content

Commit

Permalink
Update instructions for Minikube 0.29.0
Browse files Browse the repository at this point in the history
Changed the documentation to work for minikube 0.29.0,
as well as updating the development tools.
  • Loading branch information
markmandel committed Oct 4, 2018
1 parent 3704ab3 commit 3fdbdfe
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
5 changes: 2 additions & 3 deletions build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -421,9 +421,8 @@ minikube-test-cluster: DOCKER_RUN_ARGS+=--network=host -v $(minikube_cert_mount)
minikube-test-cluster: $(ensure-build-image) minikube-agones-profile
# localkube bootstrapper fixes issues with profiles
$(MINIKUBE) start --kubernetes-version v1.10.0 --vm-driver $(MINIKUBE_DRIVER) \
--bootstrapper=localkube \
--extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
--extra-config=apiserver.Authorization.Mode=RBAC
--extra-config=apiserver.admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
--extra-config=apiserver.authorization-mode=RBAC
# wait until the master is up
until docker run --rm $(common_mounts) $(DOCKER_RUN_ARGS) $(build_tag) kubectl cluster-info; \
do \
Expand Down
3 changes: 1 addition & 2 deletions build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,7 @@ This will setup a [Minikube](https://github.com/kubernetes/minikube) cluster, ru
Because Minikube runs on a virtualisation layer on the host, some of the standard build and development Make targets
need to be replaced by Minikube specific targets.

> We recommend installing version [0.28.0 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.28.0),
due to issues with other versions
> We recommend installing version [0.29.0 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.29.0).
First, [install Minikube](https://github.com/kubernetes/minikube#installation), which may also require you to install
a virtualisation solution, such as [VirtualBox](https://www.virtualbox.org) as well.
Expand Down
8 changes: 3 additions & 5 deletions install/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,7 @@ a virtualisation solution, such as [VirtualBox][vb] as well.
[minikube]: https://github.com/kubernetes/minikube#installation
[vb]: https://www.virtualbox.org

> We recommend installing version [0.28.0 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.28.0),
due to issues with other versions
> We recommend installing version [0.29.0 of minikube](https://github.com/kubernetes/minikube/releases/tag/v0.29.0).
## Creating an `agones` profile

Expand All @@ -167,9 +166,8 @@ replaced by a [vm-driver](https://github.com/kubernetes/minikube#requirements) o

```bash
minikube start --kubernetes-version v1.10.0 --vm-driver virtualbox \
--bootstrapper=localkube \
--extra-config=apiserver.Admission.PluginNames=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
--extra-config=apiserver.Authorization.Mode=RBAC
--extra-config=apiserver.admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota \
--extra-config=apiserver.authorization-mode=RBAC
```

> the --bootstrapper=localkube is required since we aren't using the `default` profile. ([bug](https://github.com/kubernetes/minikube/issues/2717))
Expand Down

0 comments on commit 3fdbdfe

Please sign in to comment.