Skip to content

Commit

Permalink
Adding goimports back into the build shell.
Browse files Browse the repository at this point in the history
  • Loading branch information
@markmandel
markmandel committed Sep 11, 2018
1 parent 2d8c351 commit 5ee93f8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion build/build-image/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ RUN mkdir -p /go/src/github.com/golang && cd /go/src/github.com/golang && \
go install github.com/golang/protobuf/protoc-gen-go

# install go tooling for development, building and testing
RUN go get -u github.com/golang/dep/cmd/dep
RUN go get -u github.com/golang/dep/cmd/dep && \
go get -u golang.org/x/tools/cmd/goimports

# install golang-ci linter
RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | \
Expand Down

4 comments on commit 5ee93f8

@slartibaartfast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can use packages that are not in the vendor tree?

@markmandel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slartibaartfast sorry, I'm not sure I understand the question?

@slartibaartfast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be vague. Does the use of goimports mean that packages referenced in the import section of a go file will be imported and incorporated into the build if they are not found locally? And if so, does that mean that I could do something like submit a pr that imports a package such as github.com/gin-gonic/gin without breaking the build?

@markmandel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you. No, this is just adding the binary for goimports, so it's available in the Docker developer shell. That's it.

Please sign in to comment.