Skip to content

Commit

Permalink
Improve SDK Conformance error reporting (#3331)
Browse files Browse the repository at this point in the history
* Improve SDK Conformance error reporting

Attempting to make it easier to see when and how SDK conformance tests
either pass or fail.
  • Loading branch information
markmandel committed Aug 18, 2023
1 parent 4c51220 commit fc0e07d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions build/includes/sdk.mk
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,13 @@ run-sdk-conformance-no-build: ensure-build-sdk-image
run-sdk-conformance-test: TRIES=5
run-sdk-conformance-test: ensure-agones-sdk-image
run-sdk-conformance-test: ensure-build-sdk-image
@echo "\n\n^^^ Building: $(SDK_FOLDER)\n\n"
$(MAKE) run-sdk-command COMMAND=build-sdk-test
for try in `seq 1 $(TRIES)`; do \
$(MAKE) run-sdk-conformance-no-build && echo "+++ Success: $(SDK_FOLDER)" && break || \
status=$$? && echo "*** Failure: $(SDK_FOLDER), try $$try/$(TRIES)"; \
done; (exit $$status)
@for try in `seq 1 $(TRIES)`; do \
echo "\n\n>>> Starting: ($$try/$(TRIES)) $(SDK_FOLDER)\n\n" && \
$(MAKE) run-sdk-conformance-no-build && echo "\n\n+++ Success: ($$try/$(TRIES)) $(SDK_FOLDER)\n\n" && break || \
echo "\n\n*** Failure: ($$try/$(TRIES)) $(SDK_FOLDER)\n\n" && false; \
done

run-sdk-conformance-test-cpp:
$(MAKE) run-sdk-conformance-test SDK_FOLDER=cpp GRPC_PORT=9003 HTTP_PORT=9103
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ steps:
- cpp-sdk-build-restore-cache
- ensure-build-sdk-image-base
dir: "build"
args: [ "-j", "4", "--output-sync=target", "build-sdks"]
args: [ "-j", "4", "--output-sync=recurse", "build-sdks"]

#
# Cache the cpp sdk build directory, to speed up subsequent builds (considerably)
Expand Down

0 comments on commit fc0e07d

Please sign in to comment.