Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests should use a randomly created Namespace for testing #1074

Closed
pooneh-m opened this issue Sep 25, 2019 · 4 comments · Fixed by #1623
Closed

E2E tests should use a randomly created Namespace for testing #1074

pooneh-m opened this issue Sep 25, 2019 · 4 comments · Fixed by #1623
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break
Milestone

Comments

@pooneh-m
Copy link
Contributor

Is your feature request related to a problem? Please describe.
All E2E tests are using default namespace in the test cluster when running, which makes it harder to identify which test is causing issues in the shared cluster. Tests are also more error prone by mistakenly reusing resources from other tests in the same namespace.

Describe the solution you'd like
Test runs should be isolated to their own namespaces.

@pooneh-m pooneh-m added the kind/feature New features for Agones label Sep 25, 2019
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break and removed kind/feature New features for Agones labels Sep 25, 2019
@markmandel
Copy link
Member

Interesting idea! Is this mainly to make it easier to parse logs?

@pooneh-m
Copy link
Contributor Author

Yes, and if there is a leak from testing like what we saw few days ago, it is easier to debug. WDYT?

@pooneh-m
Copy link
Contributor Author

Also, at the test cleanup, deleting the namespace deletes all the resources. There is no need to delete resources one by one from default namespace.

@aLekSer
Copy link
Collaborator

aLekSer commented Jun 9, 2020

@akremsa can start working on this. In two steps:

  1. Add new variable NAMESPACE for make install and make test-e2e
  2. Change e2e.sh in e2e-runner image and cloudbuild.yaml
    Namespace could contain timestamp or git commitID (hash of commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants