Fixes, more e2e tests and logging for multi-cluster allocation #1077

pooneh-m · 2019-09-26T00:26:40Z

Improvements and bug fixed for multi-cluster allocation #597
The feature is on v1alpha1.

Bug fixed:

Fixed the remote allocation URL
Fixed the current cluster identification to condition on the allocation IPs and namespace instead of cluster name which is random.

Logging:

Added more logging to help with allocation request debugging

Testing:

Added E2E testing for remote cluster allocation base on the allocation policy, using same test cluster but different namespaces.
Removed "InsecureSkipVerify: true" and generate self-signed client and server certificates to be used by the allocator service. Lack of server validation resulted in not detecting Changed remote cluster to validate PEM certificate instead of DER #1066
Testing allocator in a none default namespace which also partially addresses this E2E tests should use a randomly created Namespace for testing #1074.

agones-bot · 2019-09-26T00:35:02Z

Build Failed 😱

Build Id: f6177acd-ad20-4ac1-ba9e-99b803698f3c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-26T00:51:27Z

Build Failed 😱

Build Id: 2ade384e-0844-4f4c-b515-7b9150781313

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pooneh-m · 2019-09-26T06:40:27Z

@markmandel e2e tests are failing because, the test cannot add a rolebinding to a newly created namespace:

rolebindings.rbac.authorization.k8s.io is forbidden: User "258182270954@cloudbuild.gserviceaccount.com" cannot create resource "rolebindings" in API group "rbac.authorization.k8s.io" in the namespace "allocator-56962236-dff7-11e9-b771-0242c0a80a06"

Can we give the account permission to create rolebinding to allow tests run on randomly created namespaces?

markmandel · 2019-09-26T15:37:53Z

@pooneh-m you should have access to the project to make the appropriate changes. Let me know if you don't, and I'll take a look.

agones-bot · 2019-09-26T17:55:32Z

Build Succeeded 👏

Build Id: ea0c299a-d57a-47c7-b3d0-f3b0848b571b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-fe3e81e
image: gcr.io/agones-images/agones-sdk:1.1.0-fe3e81e
image: gcr.io/agones-images/agones-ping:1.1.0-fe3e81e
Linux C++ SDK (build): agonessdk-1.1.0-fe3e81e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-fe3e81e.zip

A preview of the website (the last 30 builds are retained):

https://fe3e81e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1077/head:pr_1077 && git checkout pr_1077
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-fe3e81e

pooneh-m · 2019-09-26T17:57:28Z

@markmandel thanks, changing cloudbuild account role to k8s admin fixed the issue.

agones-bot · 2019-09-27T17:08:55Z

Build Failed 😱

Build Id: 359451b0-4c05-42d1-b51c-42719fc0f24f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-27T18:54:50Z

Build Succeeded 👏

Build Id: e7b8e5b3-9582-4e6d-85bf-b871829fe6cb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-c70f68f
image: gcr.io/agones-images/agones-sdk:1.1.0-c70f68f
image: gcr.io/agones-images/agones-ping:1.1.0-c70f68f
Linux C++ SDK (build): agonessdk-1.1.0-c70f68f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-c70f68f.zip

A preview of the website (the last 30 builds are retained):

https://c70f68f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1077/head:pr_1077 && git checkout pr_1077
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-c70f68f

pooneh-m · 2019-09-27T19:19:32Z

Friendly ping.

install/yaml/install.yaml

pkg/gameserverallocations/allocator.go

test/e2e/framework/framework.go

…ation and more testing

agones-bot · 2019-09-30T20:26:56Z

Build Succeeded 👏

Build Id: d1b42a16-cb78-4f3b-8341-0e534ce2ea10

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-ad4c9fa
image: gcr.io/agones-images/agones-sdk:1.1.0-ad4c9fa
image: gcr.io/agones-images/agones-ping:1.1.0-ad4c9fa
Linux C++ SDK (build): agonessdk-1.1.0-ad4c9fa-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-ad4c9fa.zip

A preview of the website (the last 30 builds are retained):

https://ad4c9fa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1077/head:pr_1077 && git checkout pr_1077
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-ad4c9fa

ilkercelikyilmaz · 2019-09-30T21:19:35Z

LGTM

ilkercelikyilmaz

LGTM

markmandel

Extra approved

google-oss-robot · 2019-10-01T00:01:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ilkercelikyilmaz, markmandel, pooneh-m
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-10-01T00:05:17Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-10-01T00:30:03Z

Build Succeeded 👏

Build Id: 86eafbb6-a897-4bc2-8956-081f9e648f92

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-7838eef
image: gcr.io/agones-images/agones-sdk:1.1.0-7838eef
image: gcr.io/agones-images/agones-ping:1.1.0-7838eef
Linux C++ SDK (build): agonessdk-1.1.0-7838eef-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-7838eef.zip

A preview of the website (the last 30 builds are retained):

https://7838eef-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1077/head:pr_1077 && git checkout pr_1077
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7838eef

agones-bot · 2019-10-01T00:47:43Z

Build Succeeded 👏

Build Id: fee29745-4691-461c-b774-6ef58927cd6d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-301e194
image: gcr.io/agones-images/agones-sdk:1.1.0-301e194
image: gcr.io/agones-images/agones-ping:1.1.0-301e194
Linux C++ SDK (build): agonessdk-1.1.0-301e194-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-301e194.zip

A preview of the website (the last 30 builds are retained):

https://301e194-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1077/head:pr_1077 && git checkout pr_1077
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-301e194

google-oss-robot added the size/L label Sep 26, 2019

pooneh-m force-pushed the namespace branch from a3c3b94 to 7a870a3 Compare September 26, 2019 00:36

pooneh-m mentioned this pull request Sep 26, 2019

TestAllocator is flakey #1050

Closed

pooneh-m force-pushed the namespace branch from 7a870a3 to fe3e81e Compare September 26, 2019 17:33

pooneh-m requested a review from markmandel September 26, 2019 23:51

create server TLS and client secrets for allocator service

40a29da

pooneh-m force-pushed the namespace branch from fe3e81e to 957e337 Compare September 27, 2019 16:53

google-oss-robot added size/XL and removed size/L labels Sep 27, 2019

pooneh-m changed the title ~~Create server and client TLS certs for allocator service~~ Fixes, more e2e tests and logging for multi-cluster allocation Sep 27, 2019

pooneh-m force-pushed the namespace branch from 957e337 to c70f68f Compare September 27, 2019 18:30

markmandel reviewed Sep 27, 2019

View reviewed changes

Add more logging to allocation, fixed allocation URL for remote alloc…

ad4c9fa

…ation and more testing

pooneh-m force-pushed the namespace branch from c70f68f to ad4c9fa Compare September 30, 2019 20:02

pooneh-m requested a review from markmandel September 30, 2019 20:30

ilkercelikyilmaz approved these changes Sep 30, 2019

View reviewed changes

google-oss-robot assigned ilkercelikyilmaz Sep 30, 2019

google-oss-robot added the lgtm label Sep 30, 2019

markmandel added this to the 1.1.0 milestone Oct 1, 2019

markmandel approved these changes Oct 1, 2019

View reviewed changes

google-oss-robot assigned markmandel Oct 1, 2019

Merge branch 'master' into namespace

7838eef

google-oss-robot removed the lgtm label Oct 1, 2019

Merge branch 'master' into namespace

301e194

markmandel merged commit 3caee5c into googleforgames:master Oct 1, 2019

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones labels Oct 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes, more e2e tests and logging for multi-cluster allocation #1077

Fixes, more e2e tests and logging for multi-cluster allocation #1077

pooneh-m commented Sep 26, 2019 •

edited

Loading

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

pooneh-m commented Sep 26, 2019

markmandel commented Sep 26, 2019

agones-bot commented Sep 26, 2019

pooneh-m commented Sep 26, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

pooneh-m commented Sep 27, 2019

agones-bot commented Sep 30, 2019

ilkercelikyilmaz commented Sep 30, 2019

ilkercelikyilmaz left a comment

markmandel left a comment

google-oss-robot commented Oct 1, 2019

google-oss-robot commented Oct 1, 2019

agones-bot commented Oct 1, 2019

agones-bot commented Oct 1, 2019

Fixes, more e2e tests and logging for multi-cluster allocation #1077

Fixes, more e2e tests and logging for multi-cluster allocation #1077

Conversation

pooneh-m commented Sep 26, 2019 • edited Loading

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

pooneh-m commented Sep 26, 2019

markmandel commented Sep 26, 2019

agones-bot commented Sep 26, 2019

pooneh-m commented Sep 26, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

pooneh-m commented Sep 27, 2019

agones-bot commented Sep 30, 2019

ilkercelikyilmaz commented Sep 30, 2019

ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Oct 1, 2019

google-oss-robot commented Oct 1, 2019

agones-bot commented Oct 1, 2019

agones-bot commented Oct 1, 2019

pooneh-m commented Sep 26, 2019 •

edited

Loading