Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a root OWNERS file for agones #1112

Closed
fejta opened this issue Oct 14, 2019 · 1 comment · Fixed by #1113
Closed

Please create a root OWNERS file for agones #1112

fejta opened this issue Oct 14, 2019 · 1 comment · Fixed by #1113
Assignees
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Milestone

Comments

@fejta
Copy link

fejta commented Oct 14, 2019

Can you create OWNERS files? At least one in the root dir.

/assign @roberthbailey

{
 insertId: "x0pnb4f8jk0fp"  
 jsonPayload: {
  author: "pooneh-m"   
  component: "hook"   
  event-GUID: "7a7a5af0-eeae-11e9-92e0-9607e4f41e57"   
  event-type: "pull_request"   
  file: "prow/plugins/approve/approvers/owners.go:164"   
  func: "k8s.io/test-infra/prow/plugins/approve/approvers.Owners.GetSuggestedApprovers"   
  level: "warning"   
  msg: "Couldn't find/suggest approvers for each files. Unapproved: [""]"   
  org: "googleforgames"   
  plugin: "approve"   
  pr: 1110   
  repo: "agones"   
  url: "https://github.com/googleforgames/agones/pull/1110"   
 }
 labels: {…}  
 logName: "projects/oss-prow/logs/hook"  
 receiveTimestamp: "2019-10-14T18:14:48.747545067Z"  
 resource: {…}  
 severity: "ERROR"  
 timestamp: "2019-10-14T18:14:41Z"  
}
@fejta fejta added the kind/bug These are bugs. label Oct 14, 2019
@roberthbailey
Copy link
Member

I could have sworn that I did this.... I looked through my PR history and found #1016, where I apparently created an owners file in the build directory (even though the PR title says "at the root of the repository"). Oops.

@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. area/tests Unit tests, e2e tests, anything to make sure things don't break and removed area/meta Organisational matters. e.g. Governance, release cycles, etc. labels Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants