Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Remove obsolete example of FleetAllocator service #1584

Closed
aLekSer opened this issue May 26, 2020 · 1 comment · Fixed by #1620 or #1624
Closed

Cleanup: Remove obsolete example of FleetAllocator service #1584

aLekSer opened this issue May 26, 2020 · 1 comment · Fixed by #1620 or #1624
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Milestone
1.7.0

Comments

@aLekSer
Copy link
Collaborator

aLekSer commented May 26, 2020 •
edited
Loading

Some parts, for example, waiting for Ready Replicas is redundant in this example code:
cd874a2
This code is misleading and should be removed soon.
GameServerAllocation should be used for this purpose:
https://agones.dev/site/docs/getting-started/create-fleet/#4-allocate-a-game-server-from-the-fleet
AllocatorService could be used also:
https://agones.dev/site/docs/advanced/allocator-service/
@aLekSer aLekSer added the kind/cleanup Refactoring code, fixing up documentation, etc label May 26, 2020
@aLekSer aLekSer changed the title Remove obsolete example of FleetAllocator service Cleanup: Remove obsolete example of FleetAllocator service May 26, 2020
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones labels May 26, 2020
@aLekSer
Copy link
Collaborator Author

aLekSer commented Jun 5, 2020

Slack conversation:
https://agones.slack.com/archives/C9DGM5DS8/p1590422798384400

@akremsa akremsa mentioned this issue Jun 9, 2020
Merged
@akremsa akremsa mentioned this issue Jun 11, 2020
Merged
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.7.0
2 participants
@markmandel @aLekSer