Remove obsolete example of FleetAllocator service #1620

akremsa · 2020-06-09T14:24:30Z

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
Removed this part because we don't use it anymore and it leads to some confusions.

Which issue(s) this PR fixes:
Closes #1584

agones-bot · 2020-06-09T14:44:44Z

Build Succeeded 👏

Build Id: 638b3179-9902-46c2-9058-702f0bd0965c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-ceaa9b8
image: gcr.io/agones-images/agones-sdk:1.7.0-ceaa9b8
image: gcr.io/agones-images/agones-ping:1.7.0-ceaa9b8
Linux C++ SDK (build): agonessdk-1.7.0-ceaa9b8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-ceaa9b8.zip

A preview of the website (the last 30 builds are retained):

https://ceaa9b8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1620/head:pr_1620 && git checkout pr_1620
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-ceaa9b8

site/content/en/docs/Examples/_index.md

markmandel · 2020-06-09T19:12:34Z

site/content/en/docs/Guides/access-api.md

@@ -302,4 +302,4 @@ section may also provide the more details on the API conventions that are used i

 ## Next Steps

- Learn how to interact with Agones programmatically through the API while creating an [Allocator Service]({{< relref "../Tutorials/allocator-service-go.md" >}}).
+- Learn how to interact with Agones programmatically, see [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) tutorial.


Suggested change

- Learn how to interact with Agones programmatically, see [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) tutorial.

- Learn how to use the [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) for single and multi-cluster Allocation.

Something like that? WDYT?

Good suggestion

markmandel · 2020-06-09T19:12:36Z

site/content/en/docs/Getting Started/create-fleet.md

@@ -359,4 +359,4 @@ You have now deployed a new version of your game!
 - Have a look at the [GameServer Creation, Allocation and Shutdown Lifecycle]({{< ref "/docs/Guides/gameserver-lifecycle.md" >}}) diagram,
    to give you a good overview of how all the pieces fit together - from creating to integrating with a matchmaker.
 - Or if you want to try to use your own GameServer container make sure you have properly integrated the [Agones SDK]({{< ref "/docs/Guides/Client SDKs/_index.md" >}}).
- If you would like to learn how to programmatically allocate a Game Server from the fleet using the Agones API, see the [Allocator Service]({{< relref "../Tutorials/allocator-service-go.md" >}}) tutorial.
+- If you would like to learn how to programmatically allocate a Game Server from the fleet using the Agones API, see [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) tutorial.


Maybe point to both https://agones.dev/site/docs/guides/access-api/ and https://agones.dev/site/docs/advanced/allocator-service/ ?

Something like?

Suggested change

- If you would like to learn how to programmatically allocate a Game Server from the fleet using the Agones API, see [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) tutorial.

- If you would like to learn how to programmatically allocate a Game Server from the fleet, see how to [Access Agones via the Kubernetes API](https://agones.dev/site/docs/guides/access-api/) or alternatively use the [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}), depending on your needs.

markmandel · 2020-06-10T17:38:02Z

Not your fault - looks like we have a 404 in our site.

markmandel · 2020-06-10T21:41:24Z

site/content/en/docs/Getting Started/create-fleet.md

@@ -359,4 +359,4 @@ You have now deployed a new version of your game!
 - Have a look at the [GameServer Creation, Allocation and Shutdown Lifecycle]({{< ref "/docs/Guides/gameserver-lifecycle.md" >}}) diagram,
    to give you a good overview of how all the pieces fit together - from creating to integrating with a matchmaker.
 - Or if you want to try to use your own GameServer container make sure you have properly integrated the [Agones SDK]({{< ref "/docs/Guides/Client SDKs/_index.md" >}}).
- If you would like to learn how to programmatically allocate a Game Server from the fleet using the Agones API, see the [Allocator Service]({{< relref "../Tutorials/allocator-service-go.md" >}}) tutorial.
+- If you would like to learn how to programmatically allocate a Game Server from the fleet, see how to [Access Agones via the Kubernetes API](https://agones.dev/site/docs/guides/access-api/) or alternatively use the [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}), depending on your needs.


The link to https://agones.dev/site/docs/guides/access-api/ should be a relref or a ref shortcode, rather than a hardcoded link to the agones website, please.

cleanup

markmandel

👍

google-oss-robot · 2020-06-10T22:13:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-06-10T22:25:03Z

Build Succeeded 👏

Build Id: 38a9dffc-07d2-41f4-a40e-37bd52e74960

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-99a751a
image: gcr.io/agones-images/agones-sdk:1.7.0-99a751a
image: gcr.io/agones-images/agones-ping:1.7.0-99a751a
Linux C++ SDK (build): agonessdk-1.7.0-99a751a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-99a751a.zip

A preview of the website (the last 30 builds are retained):

https://99a751a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1620/head:pr_1620 && git checkout pr_1620
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-99a751a

google-oss-robot · 2020-06-10T23:18:07Z

New changes are detected. LGTM label has been removed.

markmandel · 2020-06-11T17:30:59Z

Just realised, in this PR we didn't remove: https://agones.dev/site/docs/tutorials/allocator-service-go/

We should probably do that 😄

akremsa · 2020-06-11T17:37:40Z

@markmandel ok I get it

* remove obsolete example of FleetAllocator service Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from pooneh-m and roberthbailey June 9, 2020 14:24

google-oss-robot added the size/L label Jun 9, 2020

markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jun 9, 2020

markmandel reviewed Jun 9, 2020

View reviewed changes

googlebot added the cla: yes label Jun 10, 2020

markmandel reviewed Jun 10, 2020

View reviewed changes

akremsa force-pushed the remove-fleetAllocator branch from 6e265b7 to 99a751a Compare June 10, 2020 21:54

alexey-kremsa-globant added 3 commits June 11, 2020 00:56

remove obsolete example of FleetAllocator service

9119cd9

cleanup

applied review notes

5d609e5

use relref

e6e9a25

akremsa force-pushed the remove-fleetAllocator branch from 99a751a to e6e9a25 Compare June 10, 2020 21:56

markmandel approved these changes Jun 10, 2020

View reviewed changes

google-oss-robot assigned markmandel Jun 10, 2020

google-oss-robot added the lgtm label Jun 10, 2020

google-oss-robot added the approved label Jun 10, 2020

Merge branch 'master' into remove-fleetAllocator

0735f1e

google-oss-robot removed the lgtm label Jun 10, 2020

markmandel merged commit 5bafdde into googleforgames:master Jun 11, 2020

markmandel added this to the 1.7.0 milestone Jun 11, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Remove obsolete example of FleetAllocator service (googleforgames#1620)

8d0e564

* remove obsolete example of FleetAllocator service Co-authored-by: Mark Mandel <markmandel@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove obsolete example of FleetAllocator service #1620

Remove obsolete example of FleetAllocator service #1620

akremsa commented Jun 9, 2020

agones-bot commented Jun 9, 2020

markmandel Jun 9, 2020

akremsa Jun 10, 2020

markmandel Jun 9, 2020

akremsa Jun 10, 2020

markmandel commented Jun 10, 2020

markmandel Jun 10, 2020

akremsa Jun 10, 2020

markmandel left a comment

google-oss-robot commented Jun 10, 2020

agones-bot commented Jun 10, 2020

google-oss-robot commented Jun 10, 2020

markmandel commented Jun 11, 2020

akremsa commented Jun 11, 2020 •

edited

Loading

	- Learn how to interact with Agones programmatically, see [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) tutorial.
	- Learn how to use the [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) for single and multi-cluster Allocation.

	- If you would like to learn how to programmatically allocate a Game Server from the fleet using the Agones API, see [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}) tutorial.
	- If you would like to learn how to programmatically allocate a Game Server from the fleet, see how to [Access Agones via the Kubernetes API](https://agones.dev/site/docs/guides/access-api/) or alternatively use the [Allocator Service]({{< relref "../Advanced/allocator-service.md" >}}), depending on your needs.

Remove obsolete example of FleetAllocator service #1620

Remove obsolete example of FleetAllocator service #1620

Conversation

akremsa commented Jun 9, 2020

agones-bot commented Jun 9, 2020

markmandel Jun 9, 2020

Choose a reason for hiding this comment

akremsa Jun 10, 2020

Choose a reason for hiding this comment

markmandel Jun 9, 2020

Choose a reason for hiding this comment

akremsa Jun 10, 2020

Choose a reason for hiding this comment

markmandel commented Jun 10, 2020

markmandel Jun 10, 2020

Choose a reason for hiding this comment

akremsa Jun 10, 2020

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jun 10, 2020

agones-bot commented Jun 10, 2020

google-oss-robot commented Jun 10, 2020

markmandel commented Jun 11, 2020

akremsa commented Jun 11, 2020 • edited Loading

akremsa commented Jun 11, 2020 •

edited

Loading