Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky: Hugo occasionally fails: fatal error: concurrent map read and map write #1981

Closed
markmandel opened this issue Feb 3, 2021 · 1 comment · Fixed by #2085
Closed
Labels
area/site The website itself - including redirects, styling, search, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Milestone

Comments

@markmandel
Copy link
Collaborator

What happened:

Very occasionally, Hugo will fail in CI with the following error:

fatal error: concurrent map read and map write

goroutine 166 [running]:
runtime.throw(0x1e2fd5a, 0x21)
	/usr/local/go/src/runtime/panic.go:1116 +0x72 fp=0xc002a4b428 sp=0xc002a4b3f8 pc=0x4f1712
runtime.mapaccess1_faststr(0x1b27300, 0xc000cbebd0, 0xc0002b532f, 0x18, 0xc001122298)
	/usr/local/go/src/runtime/map_faststr.go:21 +0x43c fp=0xc002a4b498 sp=0xc002a4b428 pc=0x4cfc1c
github.com/gohugoio/hugo/tpl/internal/go_templates/texttemplate.(*state).walkTemplate(0xc002a4bb78, 0x1d8ce20, 0xc001120e00, 0x194, 0xc000b4e540)
	/root/project/hugo/tpl/internal/go_templates/texttemplate/exec.go:399 +0x8e fp=0xc002a4b580 sp=0xc002a4b498 pc=0xf0403e

What you expected to happen:

Not to do that.

How to reproduce it (as minimally and precisely as possible):

Run Hugo a lot.

Anything else we need to know?:

I'm not sure if it's actually been fixed in Hugo yet:
gohugoio/hugo#7293 seems to be the tracking issue.

Environment: Cloud Build

  • Agones version: dev
  • Kubernetes version (use kubectl version): N/A
  • Cloud provider or hardware configuration: N/A
  • Install method (yaml/helm): N/A
  • Troubleshooting guide log(s):
  • Others:
@markmandel markmandel added kind/bug These are bugs. help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! area/site The website itself - including redirects, styling, search, etc labels Feb 3, 2021
@roberthbailey
Copy link
Member

It looks like this is fixed in huge 0.81.0, which requires golang 1.16 or above.

markmandel added a commit to markmandel/agones that referenced this issue Apr 30, 2021
I got annoyed by this flakiness, so decided to do something about it.

Doing a check over the website, all looks exactly the same as per usual.

Closes googleforgames#1981
roberthbailey pushed a commit that referenced this issue May 1, 2021
I got annoyed by this flakiness, so decided to do something about it.

Doing a check over the website, all looks exactly the same as per usual.

Closes #1981
@sawagh sawagh added this to the 1.15.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/site The website itself - including redirects, styling, search, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants