Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fleet-tcp.yaml miss the spec of ports.protocol #2113

Closed
bigbelly1028 opened this issue May 31, 2021 · 3 comments · Fixed by #2122
Closed

fleet-tcp.yaml miss the spec of ports.protocol #2113

bigbelly1028 opened this issue May 31, 2021 · 3 comments · Fixed by #2122
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Milestone
1.16.0

Comments

@bigbelly1028
Copy link

Sample YAML for fleet TCP usage seems wrongly configured:
https://raw.githubusercontent.com/googleforgames/agones/release-1.14.0/examples/simple-game-server/fleet-tcp.yaml
After testing, there should be a 'protocol: TCP' after line 25, otherwise, it will fail to respond when applying to Kubernetes.
@bigbelly1028 bigbelly1028 added the kind/bug These are bugs. label May 31, 2021
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! labels Jun 1, 2021
@markmandel
Copy link
Member

Ah! Excellent catch!

Since you've got the example right there with the fix, would you be interesting in filing a PR to make the change?

@Rohansjamadagni
Copy link
Contributor

Hi @markmandel I would like to submit a PR, this is my first time contributing to this project!

@markmandel
Copy link
Member

Hi @markmandel I would like to submit a PR, this is my first time contributing to this project!

This is a great first issue!

@Rohansjamadagni Rohansjamadagni mentioned this issue Jun 4, 2021
Merged
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Adds the Missing TCP protocol spec to the example fleet Rohansjamadagni/agones
4 participants
@markmandel @roberthbailey @Rohansjamadagni @bigbelly1028