Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Missing TCP protocol spec to the example fleet #2122

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

Rohansjamadagni
Copy link
Contributor

@Rohansjamadagni Rohansjamadagni commented Jun 4, 2021

What type of PR is this?

/kind bug

What this PR does / Why we need it:
Adds the missing spec of ports.protocol to leet-tcp.yaml

Which issue(s) this PR fixes:

Closes #2113

Special notes for your reviewer:

@google-cla
Copy link

google-cla bot commented Jun 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Rohansjamadagni
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 4, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 67a480d2-a553-4ed2-bb7d-104f4118f0ea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2122/head:pr_2122 && git checkout pr_2122
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.15.0-323dfdc

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, Rohansjamadagni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey changed the title Adds the Missing TCP protocol spec Adds the Missing TCP protocol spec to the example fleet Jun 9, 2021
@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Jun 9, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e69049fc-e1a8-4bcf-a008-3a62d7b04666

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2122/head:pr_2122 && git checkout pr_2122
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-1951d34

@roberthbailey roberthbailey merged commit cbb709f into googleforgames:main Jun 9, 2021
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/examples Examples. Usually found in the `examples` directory cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fleet-tcp.yaml miss the spec of ports.protocol
4 participants