GameServerAllocation metadata isn't validated

[markmandel]

What happened:

When you send a GameServerAllocation (in either CRD or gRPC/REST Allocation API) with an invalid label or annotation value, rather than returning a validation error, it responds with an UnAllocated response, suggesting it could not match a GameServer

What you expected to happen:

The response should let the user know that the format for the GameServerAllocation is invalid, and why.

How to reproduce it (as minimally and precisely as possible):

apiVersion: "allocation.agones.dev/v1"
kind: GameServerAllocation
spec:
  metadata:
    labels:
      mode$$: deathmatch

Since "$$" is invalid, it will fail.

Anything else we need to know?:

Environment:

• Agones version: 1.17
• Kubernetes version (use kubectl version): Any
• Cloud provider or hardware configuration: GKE
• Install method (yaml/helm): Either
• Troubleshooting guide log(s):
• Others:

I worked out that this cause by our retry logic. Since the attempt to update the GameServer fails, it assumes the cached value is bad, and throws it away from the allocatable cache - and then retries until it runs out of game servers in the cache.

We have the ability to validate labels and annotations keys and values, so we should do that before the system attempts to actually allocate.

(I've already been working on this, PRs will slowly trickle in).

[markmandel]

I have a fix for this! Got some PR's that will come in over the next few days.