Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agones.allocator.allocationBatchWaitTime missing in Helm Configuration documentation #2837

Closed
giuseppecampanelli opened this issue Nov 30, 2022 · 0 comments · Fixed by #2838
Closed

agones.allocator.allocationBatchWaitTime missing in Helm Configuration documentation #2837

giuseppecampanelli opened this issue Nov 30, 2022 · 0 comments · Fixed by #2838
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone
1.29.0

Comments

@giuseppecampanelli
Copy link

giuseppecampanelli commented Nov 30, 2022 •
edited
Loading

What happened:

The agones.allocator.allocationBatchWaitTime helm chart configuration value is not present in https://agones.dev/site/docs/installation/install-agones/helm/#configuration but is in the chart's values.yaml file agones.allocator.allocationBatchWaitTime.

The agones.controller.allocationBatchWaitTime value on the other hand is present in both.

What you expected to happen:

agones.allocator.allocationBatchWaitTime should be present in Configuratioon
 to reflect the Helm chart value https://github.com/googleforgames/agones/blob/main/install/helm/agones/values.yaml#L212

How to reproduce it (as minimally and precisely as possible):

Visit https://agones.dev/site/docs/installation/install-agones/helm/#configuration

Anything else we need to know?:

Environment:

  • Agones version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others:
@giuseppecampanelli giuseppecampanelli added the kind/bug These are bugs. label Nov 30, 2022
@gongmax gongmax added the kind/documentation Documentation for Agones label Nov 30, 2022
markmandel added a commit to markmandel/agones that referenced this issue Dec 1, 2022
@markmandel
Docs: agones.allocator.allocationBatchWaitTime
f6c8498 
`agones.allocator.allocationBatchWaitTime` got dropped when integrating
back into the documentation, so adding it back in!

Closes googleforgames#2837
@markmandel markmandel mentioned this issue Dec 1, 2022
Merged
roberthbailey pushed a commit that referenced this issue Dec 1, 2022
@markmandel
Docs: agones.allocator.allocationBatchWaitTime (#2838)
4111abf 
`agones.allocator.allocationBatchWaitTime` got dropped when integrating
back into the documentation, so adding it back in!

Closes #2837
chiayi pushed a commit to chiayi/agones that referenced this issue Dec 13, 2022
@markmandel @chiayi
Docs: agones.allocator.allocationBatchWaitTime (googleforgames#2838)
ee03e28 
`agones.allocator.allocationBatchWaitTime` got dropped when integrating
back into the documentation, so adding it back in!

Closes googleforgames#2837
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.29.0
Development

Successfully merging a pull request may close this issue.

Docs: agones.allocator.allocationBatchWaitTime markmandel/agones
3 participants
@gongmax @giuseppecampanelli @Kalaiselvi84