Upgrade from Debian Bullseye to Bookworm #3570
Comments
markmandel
added
help wanted
|
@Kalaiselvi84 this would likely be good to for you to work on if you have run out of tasks 👍🏻 |
Kalaiselvi84
changed the title
|
@markmandel, I've a few things to discuss:
|
The standard CI process will test those -- or you can do a |
|
The command |
|
Should be run from |
Doesn't look like I got a gist / paste. Would likely need to see a draft PR and the output to help debug. |
|
Just a reminder that once #3576 is merged and published, will need to replace all the |
|
Another reminder once #3575 is is merged and published, will need to replace all the autoscaler-webhook:0.9 instances with autoscaler-webhook:0.10 with a follow up PR (e2e tests, docs, etc), |
gRPC upgrades with gRPC where very brittle, and attempts to upgrade dependencies and/or switch to a `FetchContent_Declare` type workflow were becoming increasingly time-consuming - and not resulting with a working solution. Speaking with the gRPC team, they recommended not installing dependencies within CMake (and how they do it admittedly an antipattern). So this change removes the ability for the CMakeLists.txt to install gRPC and makes finding the gRPC dependency a hard requirement, and updates the documentation accordingly. This change isn't onerous to the end user, as our SDK has only the one dependency - gRPC (which does install all its dependencies). At some point gRPC will have official support for vcpkg, at which point we should probably move with them - but in the meantime, the cpp-simple example has been updated with this change, and it's an extra ~4 lines. This update also include a lot of other fixes: * Upgrade from Debian Bullseye to Bookworm for all cpp related containers * Builds now actually happen in parallel, reducing build time to minutes not hours. * Bump to gRPC 1.57.1 * Fix bug with gRPC dependency utf8_range. * Move to C++17, because it's required for gRPC. Work on googleforgames#3570
gRPC upgrades with gRPC where very brittle, and attempts to upgrade dependencies and/or switch to a `FetchContent_Declare` type workflow were becoming increasingly time-consuming - and not resulting with a working solution. Speaking with the gRPC team, they recommended not installing dependencies within CMake (and how they do it admittedly an antipattern). So this change removes the ability for the CMakeLists.txt to install gRPC and makes finding the gRPC dependency a hard requirement, and updates the documentation accordingly. This change isn't onerous to the end user, as our SDK has only the one dependency - gRPC (which does install all its dependencies). At some point gRPC will have official support for vcpkg, at which point we should probably move with them - but in the meantime, the cpp-simple example has been updated with this change, and it's an extra ~4 lines. This update also include a lot of other fixes: * Upgrade from Debian Bullseye to Bookworm for all cpp related containers * Builds now actually happen in parallel, reducing build time to minutes not hours. * Bump to gRPC 1.57.1 * Fix bug with gRPC dependency utf8_range. * Move to C++17, because it's required for gRPC. Work on googleforgames#3570
gRPC upgrades with gRPC where very brittle, and attempts to upgrade dependencies and/or switch to a `FetchContent_Declare` type workflow were becoming increasingly time-consuming - and not resulting with a working solution. Speaking with the gRPC team, they recommended not installing dependencies within CMake (and how they do it admittedly an antipattern). So this change removes the ability for the CMakeLists.txt to install gRPC and makes finding the gRPC dependency a hard requirement, and updates the documentation accordingly. This change isn't onerous to the end user, as our SDK has only the one dependency - gRPC (which does install all its dependencies). At some point gRPC will have official support for vcpkg, at which point we should probably move with them - but in the meantime, the cpp-simple example has been updated with this change, and it's an extra ~4 lines. This update also include a lot of other fixes: * Upgrade from Debian Bullseye to Bookworm for all cpp related containers * Builds now actually happen in parallel, reducing build time to minutes not hours. * Bump to gRPC 1.57.1 * Fix bug with gRPC dependency utf8_range. * Move to C++17, because it's required for gRPC. Work on googleforgames#3570
Breaking: Remove Cmake gRPC install when not found gRPC upgrades with gRPC where very brittle, and attempts to upgrade dependencies and/or switch to a `FetchContent_Declare` type workflow were becoming increasingly time-consuming - and not resulting with a working solution. Speaking with the gRPC team, they recommended not installing dependencies within CMake (and how they do it admittedly an antipattern). So this change removes the ability for the CMakeLists.txt to install gRPC and makes finding the gRPC dependency a hard requirement, and updates the documentation accordingly. This change isn't onerous to the end user, as our SDK has only the one dependency - gRPC (which does install all its dependencies). At some point gRPC will have official support for vcpkg, at which point we should probably move with them - but in the meantime, the cpp-simple example has been updated with this change, and it's an extra ~4 lines. This update also include a lot of other fixes: * Upgrade from Debian Bullseye to Bookworm for all cpp related containers * Builds now actually happen in parallel, reducing build time to minutes not hours. * Bump to gRPC 1.57.1 * Fix bug with gRPC dependency utf8_range. * Move to C++17, because it's required for gRPC. Work on #3570
|
@markmandel, We have bullseye in build/build-image/Dockerfile - agones/build/build-image/Dockerfile Line 17 in 589f77b Are we not upgrading it? 🤔Thought your PR has the fix for the |
|
No I didn't, I just had the sdk updates. I was figuring we were blocked on https://b.corp.google.com/issues/265528492 But if you have a workaround, please go ahead and get it implemented 👍🏻 |
Just noticing we're using Debian 11 everywhere. It's currently being kept up to date with security fixes, but it would be good to be proactive and update to Debian 12.
This can definitely be done as a series of smaller PR's.
For:
https://github.com/search?q=repo%3Agoogleforgames%2Fagones%20debian%3Abullseye&type=code
Switch from
debian:bullseyetodebian:bookwormFor:
https://github.com/search?q=repo%3Agoogleforgames%2Fagones%20debian11&type=code
Switch from
gcr.io/distroless/static-debian11:nonroottogcr.io/distroless/static-debian12:nonrootThe text was updated successfully, but these errors were encountered: