Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Node.js library #538

Closed
steven-supersolid opened this issue Jan 31, 2019 · 5 comments
Closed

Create Node.js library #538

steven-supersolid opened this issue Jan 31, 2019 · 5 comments
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Milestone

Comments

@steven-supersolid
Copy link
Collaborator

We are currently using the REST API which works well but it may simplify things for new users to have a library to use with Node.js. When deploying a new Agones version with an API change, a developer would only have to update their library version. Ideally this would be published as a node module as this is idiomatic for Node.js.

There has been some discussion before about creating a gRPC client in Node.js, or the library could make REST calls directly. The gRPC route should result in generated code so would be more maintainable.

@cyriltovena
Copy link
Collaborator

@markmandel
Copy link
Member

Here are the docs on how to statically generate a grpc client in node:
https://github.com/grpc/grpc/tree/v1.18.0/examples/node/static_codegen

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jan 31, 2019
@steven-supersolid
Copy link
Collaborator Author

Nice. This may be something I can do and manually test with our current setup. I can look at porting the client tests too. Unless there is any existing work done on this?

@markmandel
Copy link
Member

Not that i'm aware of!

@steven-supersolid
Copy link
Collaborator Author

I started work on this and have created a project structure and generated the js files from .proto. Hope to spend more time on it this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

3 participants