Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON serialisation error reporting on Mutation/Validation webhooks #992

Closed
markmandel opened this issue Aug 12, 2019 · 0 comments · Fixed by #1005
Closed

JSON serialisation error reporting on Mutation/Validation webhooks #992

markmandel opened this issue Aug 12, 2019 · 0 comments · Fixed by #1005
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Milestone

Comments

@markmandel
Copy link
Member

Is your feature request related to a problem? Please describe.

If a user mistypes a yaml for a PodSpec withing a GameServer (for example), it can result in an error like:

Error from server (InternalError): error when creating "chart": Internal error occurred: failed calling admission webhook "mutations.stable.agones.dev": an error on the server ("") has prevented the request from succeeding

Which tells them nothing useful.

If they look at the controller logs, they can see it's:

error unmarshalling json at SecretVolumeSource.items
``

But that takes an extra step, and really, they shouldn't have to do that.

**Describe the solution you'd like**

When a JSON marshalling fails, (such as [this one](https://github.com/googleforgames/agones/blob/master//pkg/fleets/controller.go#L134)), it should be reported back to the user, so they can take action on it (usually its a typo).

**Describe alternatives you've considered**

We could bubble up any errors that occur to the user from a validation/mutation webhook, not just specifically the json marshalling ones.
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Aug 12, 2019
@markmandel markmandel added this to the 1.0.0 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant