-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output JSON unmarshal error as Admission response #1005
Output JSON unmarshal error as Admission response #1005
Conversation
Build Succeeded 👏 Build Id: fa547dba-9f62-4e1d-82fb-d4f3c9ddd731 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
/lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aLekSer: 0 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Add Error into response of AdmissionReview with UT.
e6d78e7
to
c4bc8b9
Compare
/assign @aLekSer |
Build Succeeded 👏 Build Id: 7efe3f00-92b2-4a48-8de6-82ba67f2544d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Now we receive output from
Here I set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this. This is going to be great for our users!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add Error into response of AdmissionReview with UT.
Closes #992 .