Build examples make target #1019

aLekSer · 2019-08-28T11:54:40Z

Add make build target to test all examples subdirectories.

Fixed xonotic.zip url along the way to new CI step.

Part of #942 .

agones-bot · 2019-08-28T12:24:56Z

Build Failed 😱

Build Id: 74c34e71-e9c3-45de-847e-ca23157198ab

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-28T13:22:40Z

Build Failed 😱

Build Id: 20212276-4b18-4469-8404-b239a0651a48

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-28T13:50:34Z

Build Failed 😱

Build Id: d4a44721-4490-4d44-a6a0-58f3833f351f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-08-28T14:19:36Z

error in rust example was found - it has a local cargo dependency:

Step #16 - "examples-build-test": make[2]: Entering directory '/workspace/examples/rust-simple'
Step #16 - "examples-build-test": cargo build --release
Step #16 - "examples-build-test": Makefile:45: recipe for target 'build-server' failed
Step #16 - "examples-build-test": make[2]: Leaving directory '/workspace/examples/rust-simple'
Step #16 - "examples-build-test": make[2]: cargo: Command not found
Step #16 - "examples-build-test": make[2]: *** [build-server] Error 127
Step #16 - "examples-build-test": make[1]: *** [build-example] Error 2
Step #16 - "examples-build-test": make: *** [build-example-rust-simple] Error 2
Step #16 - "examples-build-test": make: *** Waiting for unfinished jobs....
Step #16 - "examples-build-test": includes/sdk.mk:158: recipe for target 'build-example' failed
Step #16 - "examples-build-test": make[1]: Leaving directory '/workspace/build'
Step #16 - "examples-build-test": includes/sdk.mk:175: recipe for target 'build-example-rust-simple' failed

Skipping simple-rust directory for now.

agones-bot · 2019-08-28T14:56:20Z

Build Succeeded 👏

Build Id: 54e52f78-48c0-419d-a88f-b8d981ddf857

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-2226b34
image: gcr.io/agones-images/agones-sdk:1.0.0-2226b34
image: gcr.io/agones-images/agones-ping:1.0.0-2226b34
Linux C++ SDK (build): agonessdk-1.0.0-2226b34-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-2226b34.zip

A preview of the website (the last 30 builds are retained):

https://2226b34-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1019/head:pr_1019 && git checkout pr_1019
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-2226b34

agones-bot · 2019-09-26T17:32:32Z

Build Succeeded 👏

Build Id: d7c699f8-2d20-44a2-aa44-2727f552b592

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-ee2518d
image: gcr.io/agones-images/agones-sdk:1.1.0-ee2518d
image: gcr.io/agones-images/agones-ping:1.1.0-ee2518d
Linux C++ SDK (build): agonessdk-1.1.0-ee2518d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-ee2518d.zip

A preview of the website (the last 30 builds are retained):

https://ee2518d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1019/head:pr_1019 && git checkout pr_1019
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-ee2518d

aLekSer · 2019-09-27T11:07:32Z

About 36 minutes of executing Cloud build in total.

Add make build target as well as cloudbuild step to test all examples sources.

aLekSer · 2019-09-30T12:25:57Z

I have removed cloudbuild target, because I think it should be added for periodical builds only, not every PR:

- name: "make-docker"
  id: examples-build-test
  waitFor:
    - lint
  dir: "build"
  args: [ "-j", "5", "build-examples" ]

Note that it can be invoked manually make build-examples, it takes about 20 minutes additionally compared to current cloudbuild.

agones-bot · 2019-09-30T12:45:57Z

Build Succeeded 👏

Build Id: 042e132e-5ff9-4802-bbd4-d7d6a9bd6d84

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-67e665d
image: gcr.io/agones-images/agones-sdk:1.1.0-67e665d
image: gcr.io/agones-images/agones-ping:1.1.0-67e665d
Linux C++ SDK (build): agonessdk-1.1.0-67e665d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-67e665d.zip

A preview of the website (the last 30 builds are retained):

https://67e665d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1019/head:pr_1019 && git checkout pr_1019
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-67e665d

markmandel

Very cool!

google-oss-robot · 2019-09-30T23:46:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aLekSer, markmandel
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-09-30T23:47:21Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-10-01T00:12:00Z

Build Succeeded 👏

Build Id: 5aa9ea6e-db14-4cdf-b7c5-528d824d5a43

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-e7fe1e2
image: gcr.io/agones-images/agones-sdk:1.1.0-e7fe1e2
image: gcr.io/agones-images/agones-ping:1.1.0-e7fe1e2
Linux C++ SDK (build): agonessdk-1.1.0-e7fe1e2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-e7fe1e2.zip

A preview of the website (the last 30 builds are retained):

https://e7fe1e2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1019/head:pr_1019 && git checkout pr_1019
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e7fe1e2

google-oss-robot added do-not-merge/work-in-progress size/M labels Aug 28, 2019

aLekSer force-pushed the feature/examples-ci-build branch 2 times, most recently from f121231 to 8dada93 Compare August 28, 2019 13:18

aLekSer force-pushed the feature/examples-ci-build branch from 8dada93 to 2226b34 Compare August 28, 2019 14:25

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 10, 2019

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 17, 2019

aLekSer force-pushed the feature/examples-ci-build branch from 2226b34 to ee2518d Compare September 26, 2019 16:56

Build examples as a new CI step

67e665d

Add make build target as well as cloudbuild step to test all examples sources.

aLekSer force-pushed the feature/examples-ci-build branch from ee2518d to 67e665d Compare September 30, 2019 12:22

aLekSer changed the title ~~Build examples as a new CI step~~ Build examples make target Sep 30, 2019

aLekSer marked this pull request as ready for review September 30, 2019 12:57

google-oss-robot removed the do-not-merge/work-in-progress label Sep 30, 2019

google-oss-robot assigned markmandel Sep 30, 2019

markmandel approved these changes Sep 30, 2019

View reviewed changes

google-oss-robot added the lgtm label Sep 30, 2019

Merge branch 'master' into feature/examples-ci-build

e7fe1e2

google-oss-robot removed the lgtm label Sep 30, 2019

markmandel added this to the 1.1.0 milestone Oct 1, 2019

markmandel added area/examples Examples. Usually found in the `examples` directory area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 1, 2019

markmandel merged commit deab3ce into googleforgames:master Oct 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build examples make target #1019

Build examples make target #1019

aLekSer commented Aug 28, 2019 •

edited

Loading

agones-bot commented Aug 28, 2019

agones-bot commented Aug 28, 2019

agones-bot commented Aug 28, 2019

aLekSer commented Aug 28, 2019 •

edited

Loading

agones-bot commented Aug 28, 2019

agones-bot commented Sep 26, 2019

aLekSer commented Sep 27, 2019

aLekSer commented Sep 30, 2019

agones-bot commented Sep 30, 2019

markmandel left a comment

google-oss-robot commented Sep 30, 2019

google-oss-robot commented Sep 30, 2019

agones-bot commented Oct 1, 2019

Build examples make target #1019

Build examples make target #1019

Conversation

aLekSer commented Aug 28, 2019 • edited Loading

agones-bot commented Aug 28, 2019

agones-bot commented Aug 28, 2019

agones-bot commented Aug 28, 2019

aLekSer commented Aug 28, 2019 • edited Loading

agones-bot commented Aug 28, 2019

agones-bot commented Sep 26, 2019

aLekSer commented Sep 27, 2019

aLekSer commented Sep 30, 2019

agones-bot commented Sep 30, 2019

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Sep 30, 2019

google-oss-robot commented Sep 30, 2019

agones-bot commented Oct 1, 2019

aLekSer commented Aug 28, 2019 •

edited

Loading

aLekSer commented Aug 28, 2019 •

edited

Loading