Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky/TestGameServerShutdown #1022

Merged
merged 2 commits into from
Aug 29, 2019
Merged

flaky/TestGameServerShutdown #1022

merged 2 commits into from
Aug 29, 2019

Conversation

markmandel
Copy link
Collaborator

Increase timeout, which should solve this, as it can sometimes take up to a minute for a GameServer to shutdown and be removed.

Run 100 times and passed:
go test -v -p=32 -timeout=1h -count=100 -mod=vendor -run=^TestGameServerShutdown$ agones.dev/agones/test/e2e

@markmandel
flaky/TestGameServerShutdown
d5c86ab 
Increase timeout, which should solve this, as it can sometimes take
up to a minute for a GameServer to shutdown and be removed.

Run 100 times and passed:
go test -v -p=32 -timeout=1h -count=100 -mod=vendor -run=^TestGameServerShutdown$ agones.dev/agones/test/e2e
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Aug 29, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4807815a-ee1f-44f8-b1fa-794e8677e243

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1022/head:pr_1022 && git checkout pr_1022
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-d5c86ab

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 72a60f82-7df3-4b4b-b924-d1cc1165ed97

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1022/head:pr_1022 && git checkout pr_1022
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-fc84ddb

@markmandel markmandel added this to the 1.0 milestone Aug 29, 2019
@markmandel markmandel merged commit 2db04ce into googleforgames:master Aug 29, 2019
@markmandel markmandel deleted the flaky/TestGameServerShutdown branch August 29, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey