add vendor grpc third_party to be referenced by protos

[pooneh-m]

Following these steps: https://github.com/googleforgames/agones/blob/master/build/README.md#dependencies
Third_party directory does not get added with go mod vendor as described.

[agones-bot]

Build Succeeded 👏

Build Id: 2c4f847a-86f6-4944-8e55-31f90c35b712

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.0.0-ca6d864
• image: gcr.io/agones-images/agones-sdk:1.0.0-ca6d864
• image: gcr.io/agones-images/agones-ping:1.0.0-ca6d864
• Linux C++ SDK (build): agonessdk-1.0.0-ca6d864-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.0.0-ca6d864.zip

A preview of the website (the last 30 builds are retained):

• https://ca6d864-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1023/head:pr_1023 && git checkout pr_1023
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-ca6d864

[roberthbailey]

/assign @devjgm

[google-oss-robot]

@roberthbailey: GitHub didn't allow me to assign the following users: devjgm.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @devjgm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[agones-bot]

Build Succeeded 👏

Build Id: 8daaaa8c-6d00-43dc-9a4e-fe248b873f76

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.0.0-4841bb2
• image: gcr.io/agones-images/agones-sdk:1.0.0-4841bb2
• image: gcr.io/agones-images/agones-ping:1.0.0-4841bb2
• Linux C++ SDK (build): agonessdk-1.0.0-4841bb2-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.0.0-4841bb2.zip

A preview of the website (the last 30 builds are retained):

• https://4841bb2-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1023/head:pr_1023 && git checkout pr_1023
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-4841bb2

[markmandel]

Just so I'm 100% clear, did you add this in manually?

Happy to approve this going through, I'm just concerned it might get accidentally deleted on a go mod operation that updates the vendor directory -- such as updating the grpc-gateway library itself, will that delete this third_party directory? or will we need to manually ensure it always is there?

[markmandel]

Sounds like this is a fun(?) common problem: golang/go#26366

[pooneh-m]

Exactly, running go mod vendor recreates the vendor directory therefore removes the third_party directory.

I followed this to add the third_party directory, which is exactly what I needed:
AGONES_PATH=/wherever/your/agones/path/is
cp -R $GOPATH/pkg/mod/github.com/grpc-ecosystem/grpc-gateway@v1.5.1/third_party $AGONES_PATH/vendor/github.com/grpc-ecosystem/grpc-gateway/

Ideally we should remove the dependency to vendor and only use go.mod?

[markmandel]

Got it - so in a previous life, someone already encountered this 👍

Maybe in a future PR we could do something like make go-deps and it would do all the appropriate things...? But for the future.

I'm assuming in a future PR we are going to remove the protos in /protos and update the tooling to reference this third_party directory instead?

[pooneh-m]

Good idea.

[markmandel]

👍

[google-oss-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, pooneh-m
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 4278e263-bf32-4cdb-aced-7c69ae74a7e3

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.0.0-8c259cf
• image: gcr.io/agones-images/agones-sdk:1.0.0-8c259cf
• image: gcr.io/agones-images/agones-ping:1.0.0-8c259cf
• Linux C++ SDK (build): agonessdk-1.0.0-8c259cf-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.0.0-8c259cf.zip

A preview of the website (the last 30 builds are retained):

• https://8c259cf-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1023/head:pr_1023 && git checkout pr_1023
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-8c259cf