flaky/TestFleetScaleUpEditAndScaleDown #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase timeout on scaling -- 15 seconds wasn't that long a time. Tested by running 100 times, and it passed: `go test -v -p=32 -timeout=1h -count=100 -mod=vendor -run=^TestFleetScaleUpEditAndScaleDown$ agones.dev/agones/test/e2e`
markmandel
added
kind/cleanup
roberthbailey
approved these changes
Aug 29, 2019
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: 7d391885-3c04-4d1f-b162-a4b4a2420142 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
pooneh-m
pushed a commit
to pooneh-m/agones
that referenced
this pull request
Aug 30, 2019
Increase timeout on scaling -- 15 seconds wasn't that long a time. Tested by running 100 times, and it passed: `go test -v -p=32 -timeout=1h -count=100 -mod=vendor -run=^TestFleetScaleUpEditAndScaleDown$ agones.dev/agones/test/e2e`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase timeout on scaling -- 15 seconds wasn't that long a time.
Tested by running 100 times, and it passed:
go test -v -p=32 -timeout=1h -count=100 -mod=vendor -run=^TestFleetScaleUpEditAndScaleDown$ agones.dev/agones/test/e2e