Define the proto definition for the allocator service #1025
Conversation
|
Build Failed 😱 Build Id: f93996f1-e4b3-4fa7-a76d-c771e4776340 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Upgrading the protobuf package to fix the build error for proto3 dependency: #1027 |
There was a problem hiding this comment.
Looks like this issue is the linter is failing on the generated code. I think you will need to have a line "This code was autogenerated. Do not edit directly." - which is included in https://github.com/googleforgames/agones/blob/master/build/boilerplate.go.txt
May be easier to get all the make commands working in this PR?
| @@ -0,0 +1,539 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
There was a problem hiding this comment.
This will need a licence header as well. We have examples in the sdk gen tooling on how we did this.
There was a problem hiding this comment.
Looks like this issue is the linter is failing on the generated code. I think you will need to have a line "This code was autogenerated. Do not edit directly." - which is included in https://github.com/googleforgames/agones/blob/master/build/boilerplate.go.txt
May be easier to get all the make commands working in this PR?
Thanks, yes I am working on the make commands. Will update this PR when done.
|
Build Failed 😱 Build Id: 53546aba-8738-4c69-ba4d-77c7ca812182 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 0cd0daef-cc21-4031-a64c-f1614ea55be9 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Just checking this is good for review - happy to do so, but noticed it's been pared back to just the proto. Wasn't sure if more was coming. |
|
To keep the reviews focused, I broke down the PR to two, one for the proto and one for the generated code and the scripts for code generation. I'll send the latter PR by the end of today. |
markmandel
added
area/user-experience
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markmandel, pooneh-m The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: e2d99487-262a-4f52-8718-ccfa0dd4e97a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
…o the gameserverallocation Extention API server.
|
Build Succeeded 👏 Build Id: ab726cdb-362c-4e7a-b577-4a5ef71193ab The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Define the v1alpha1 gRPC API protobuf definition for the allocator service according to the GameServerAllocation Extension API server.
issue: #597