-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cpp SDK. Fixed regex for version detection. Fixed mingw build. #1029
Cpp SDK. Fixed regex for version detection. Fixed mingw build. #1029
Conversation
Build Failed 😱 Build Id: 08560209-0748-4193-901c-d504d001e38b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 1a136532-e922-4a44-8cb1-3dab322e693d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
I'm not sure, why tests are failed. I didn't touch any documentation. |
I performed > git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1029/head:pr_1029 && git checkout pr_1029
> make test-gen-api-docs
{{% feature publishVersion="0.12.0" %}}
sort /Users/alex/go/src/agones.dev/agones/site/content/en/docs/Reference/agones_crd_api_reference.html > /tmp/result.sorted
diff -bB /tmp/result.sorted /tmp/generated.html.sorted All is fine no errors. On CI build it generates an error, which is strange. |
I would suggest rebasing master into your branch -- sounds like you are working off some super old code. |
Ah, there was an issue which I just fixed #1031 - waiting for it to be merged. That will actually solve the build issue |
#1031 has merged. |
Build Succeeded 👏 Build Id: bd56b5e6-b639-4e65-b2d7-4cd6a59c3e0a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Calling @devjgm 👋 - Please take a look |
My cmake-fu is not very strong. So, I'll say this LGTM, but I am not a cmake expert and I'm the furthest thing from a windows/mingw expert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @devjgm's lgtm.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dsazonoff, roberthbailey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: a219057b-5329-4ebd-8301-0d7daddba273 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Fixed Agones version detection for CMake scripts (based on git tag).
Fixed mingw (windows) build of zlib and gRPC dependency.
Added more informative error for mingw build, if OpenSSL was not found (rare case); because building of OpenSSL with mingw in a cross-platform way is tricky (require CMake->MSYS->OpenSSL chain). I'm not sure that we should add an instruction how to build OpenSSL to our documentation. Prebuilt OpenSSL for windows may be found there. OpenSSL is required only for successful gRPC build.