Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust SDK: Reserved #1030

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Rust SDK: Reserved #1030

merged 1 commit into from
Sep 9, 2019

Conversation

markmandel
Copy link
Member

Implements Reserved, as well as associated tests and examples updated.

Completes Rust work on #927

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Sep 3, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a29aca22-a807-40b9-af51-ce41a2741420

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 60724462-118f-4b4d-b5d1-e9b2b66a5b8f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6a72f6cc-b596-4d04-80d2-f6eb475d8e2a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1030/head:pr_1030 && git checkout pr_1030
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-d5193d1

@roberthbailey
Copy link
Member

Who would be a good reviewer for this?

@markmandel
Copy link
Member Author

@thara are you able to take a look at my Rust please?

@thara
Copy link
Contributor

thara commented Sep 7, 2019

@markmandel LGTM 👍

roberthbailey
roberthbailey reviewed Sep 9, 2019
View reviewed changes
site/content/en/docs/Guides/Client SDKs/rust.md Outdated
@@ -52,6 +52,13 @@ To mark the [game session as ready]({{< relref "_index.md#ready" >}}) call `sdk.
sdk.ready()?;
```


{{% feature publishVersion-="1.0.0" %}}To mark that the [reserve the game session]({{< relref "_index.md#reserve-seconds" >}}) for a duration call `sdk.reserve(duration)`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't read very well:

To mark that the reserve the game session for a duration call sdk.reserve(duration).

Maybe something like "To mark the game server as reserved for a period of time, call reserve(duration)." (this also matches the nodejs documentation).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know what I was typing on this one. Lemme fix this now, better to have it for 1.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@roberthbailey
Copy link
Member

/assign @thara
/assign @roberthbailey

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8bc9f13f-fecf-4f35-8cda-fdb136c670b2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1030/head:pr_1030 && git checkout pr_1030
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-d8052bb

@markmandel
Rust SDK: Reserved
77355f6 
Implements Reserved, as well as associated tests and examples
updated.

Completes Rust work on googleforgames#927
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2b577ff5-9390-4cf9-9409-bed143e64c6d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1030/head:pr_1030 && git checkout pr_1030
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-77355f6

@roberthbailey roberthbailey merged commit 228c916 into googleforgames:master Sep 9, 2019
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the feature/rust-reserve branch September 9, 2019 18:28
@markmandel markmandel added this to the 1.0.0 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@thara thara

@roberthbailey roberthbailey

Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/M
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @roberthbailey @thara @google-oss-robot