Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRASH for simple-udp example #1032

Merged
merged 2 commits into from
Sep 4, 2019
Merged

CRASH for simple-udp example #1032

merged 2 commits into from
Sep 4, 2019

Conversation

markmandel
Copy link
Member

This provides the CRASH command, to make GameServer crash testing easier.

This also includes a new param to disable automatically moving to Ready on startup, to enable testing crash events before and after a Ready state has been achieved.

I'll push up the image on PR merge.

Work on #956

@markmandel
CRASH for simple-udp example
795b242 
This provides the CRASH command, to make GameServer crash testing
easier.

This also includes a new param to disable automatically moving to
`Ready` on startup, to enable testing crash events before and after
a `Ready` state has been achieved.

Work on googleforgames#956
@markmandel markmandel added kind/feature New features for Agones area/examples Examples. Usually found in the `examples` directory area/tests Unit tests, e2e tests, anything to make sure things don't break labels Sep 3, 2019
@markmandel
Copy link
Member Author

/cc @aLekSer for visibility.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bbd2b328-cb33-48b1-90f2-554df135911c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 85a9e3a0-df4d-40c5-a189-23f329a9dc74

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Weird error in the build log

Get https://gcr.io/v2/: dial tcp: lookup gcr.io on [::1]:53: read udp [::1]:47564->[::1]:53: read: connection refused
includes/build-image.mk:60: recipe for target 'push-remote-build-image' failed

Trying again.

@markmandel
Copy link
Member Author

Yeah that happened to me yesterday as well. Some gcr.io flakiness it seems.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 31b1e551-bea6-4e26-a6ee-1d3807f1c6c9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1032/head:pr_1032 && git checkout pr_1032
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-8241096

@roberthbailey roberthbailey merged commit ff2c0fc into googleforgames:master Sep 4, 2019
@markmandel markmandel deleted the example/crash branch September 4, 2019 17:51
@markmandel markmandel added this to the 1.0 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
area/examples Examples. Usually found in the `examples` directory area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey