Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking Gameservers with Evicted backing Pods as Unhealthy #1056

Merged
merged 3 commits into from
Sep 22, 2019
Merged

Marking Gameservers with Evicted backing Pods as Unhealthy #1056

merged 3 commits into from
Sep 22, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Sep 12, 2019 •
edited
Loading

Add additional health check to the Gameservers Controller.
E2E test added which set Ephemeral Storage limit to 0 MB and wait for Unhealthy state.

Closes #1028 .

@aLekSer aLekSer changed the title Marking Evicted Pods as Unhealthy Marking Gameservers with Evicted backing Pods as Unhealthy Sep 12, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7b8048a8-b1a1-47c5-a73b-65a79671a197

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3e80c8d3-10f4-4f0f-945f-69e9aefb3e81

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ca9d084a-369f-48b9-808f-93cf369abb63

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4b52e352-2172-477f-8a33-6baf9ed3799f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1056/head:pr_1056 && git checkout pr_1056
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-bceb0da

@aLekSer
Copy link
Collaborator Author

aLekSer commented Sep 20, 2019 •
edited
Loading

Added an E2E test for this feature and the mark it as Ready for Review.

@aLekSer aLekSer marked this pull request as ready for review September 20, 2019 13:24
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4dc94e91-f35f-4806-8030-a3f97f1141fc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Marking Evicted Pods as Unhealthy
f1d4098 
Add aditional health check for Gameservers Controller.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 84994d50-f1b6-460e-9e25-77a915801f2b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1056/head:pr_1056 && git checkout pr_1056
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-f1d4098

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aLekSer, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b51d434c-8f29-43b9-afe3-383b6605cc48

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a051fbe6-8145-4c53-b24f-799e37b5d9f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7e4ed8f1-e563-4e95-8f07-785fc34f3dce

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1056/head:pr_1056 && git checkout pr_1056
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-519f278

@markmandel markmandel merged commit 84fae81 into googleforgames:master Sep 22, 2019
@aLekSer aLekSer deleted the unhealthy-evicted-pods branch September 23, 2019 10:13
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added the kind/bug These are bugs. label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
kind/bug These are bugs. size/S
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

GameServer status does not account for Evicted Pods
5 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @markmandel