Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allocation policy namespace field to the CRD #1067

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

pooneh-m
Copy link
Contributor

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 073457ae-76d2-4b50-ba87-2e7ba4cfb5f2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 488690c9-d39c-42d2-b708-8ffec819a2d2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c42a2a5b-f7e2-4b93-b9b9-41de20c860c1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1067/head:pr_1067 && git checkout pr_1067
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b68908c

@markmandel
Copy link
Collaborator

Just to be 100% sure, this is basically making required this code here - yes?

@pooneh-m
Copy link
Contributor Author

Yes, it was not added it to the yaml file.

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Sep 25, 2019
@markmandel markmandel added this to the 1.1.0 milestone Sep 25, 2019
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, pooneh-m
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bd0efdf8-1bd5-4bce-be38-d7b20fb6afb0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1067/head:pr_1067 && git checkout pr_1067
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-8304609

@markmandel markmandel merged commit 4f9f701 into googleforgames:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants