Add SDK server HTTP API test #1079

aLekSer · 2019-09-26T14:34:29Z

Add conformance test for Rest API SDK server port 59358.
Does not contain swagger pregenerated files. Switched Go file to other
file extension, because it is not possible to exclude one file from
GolangCI linter run.

For #927

aLekSer · 2019-09-26T14:40:14Z

I am trying to avoid autogenerated code from including to this PR. So I generate swagger folder inside docker. And clean all files using clean command.
There is an issue in golangci-lint that it is not possible not to include all dependent files to the PR:
golangci/golangci-lint#301
That's why I have added .go.nolint extension and copy file write before an execution using go run.
Other ways to resolve an issue with golangci-lint limitations would be:

Use Node JS client code, which would run all queries
Add Swagger auto generated code to Agones repo
Use bash script with curl

agones-bot · 2019-09-26T14:48:02Z

Build Failed 😱

Build Id: 12c7eadd-db95-4cd9-a1a2-ae8ff8b2d38d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-26T15:18:27Z

Build Failed 😱

Build Id: 4603a107-eb07-4de1-a960-7a155c5f8c5f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-27T11:39:07Z

Build Failed 😱

Build Id: ace3b3a2-ef72-45b9-8e63-0054141b5b9d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-27T12:38:38Z

Build Succeeded 👏

Build Id: 957d39ed-fd87-4d32-b8eb-47a9d3e54843

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-feb78e3
image: gcr.io/agones-images/agones-sdk:1.1.0-feb78e3
image: gcr.io/agones-images/agones-ping:1.1.0-feb78e3
Linux C++ SDK (build): agonessdk-1.1.0-feb78e3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-feb78e3.zip

A preview of the website (the last 30 builds are retained):

https://feb78e3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-feb78e3

aLekSer · 2019-10-07T17:39:32Z

/assign @roberthbailey
This is an HTTP endpoint test.

agones-bot · 2019-10-07T18:02:15Z

Build Succeeded 👏

Build Id: a880bf40-bc36-4d32-8794-ad35adf1db44

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-dbdb640
image: gcr.io/agones-images/agones-sdk:1.1.0-dbdb640
image: gcr.io/agones-images/agones-ping:1.1.0-dbdb640
Linux C++ SDK (build): agonessdk-1.1.0-dbdb640-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-dbdb640.zip

A preview of the website (the last 30 builds are retained):

https://dbdb640-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-dbdb640

agones-bot · 2019-10-07T18:41:14Z

Build Succeeded 👏

Build Id: fe9e76c6-b5d7-407a-b9a4-ace613464d2c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-de1259a
image: gcr.io/agones-images/agones-sdk:1.1.0-de1259a
image: gcr.io/agones-images/agones-ping:1.1.0-de1259a
Linux C++ SDK (build): agonessdk-1.1.0-de1259a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-de1259a.zip

A preview of the website (the last 30 builds are retained):

https://de1259a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-de1259a

agones-bot · 2019-10-07T21:48:17Z

Build Succeeded 👏

Build Id: 31b66424-d8d3-429e-a561-a7dcbd7a58d6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-bb0d420
image: gcr.io/agones-images/agones-sdk:1.1.0-bb0d420
image: gcr.io/agones-images/agones-ping:1.1.0-bb0d420
Linux C++ SDK (build): agonessdk-1.1.0-bb0d420-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-bb0d420.zip

A preview of the website (the last 30 builds are retained):

https://bb0d420-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-bb0d420

roberthbailey · 2019-10-08T03:27:24Z

Can you explain why http-api-test.go.nolint can't pass the linter?

roberthbailey

I'm really excited to have a conformance test for the rest apis. Thanks for putting together this PR.

roberthbailey · 2019-10-08T03:29:55Z

build/includes/sdk.mk

@@ -129,11 +133,12 @@ run-sdk-conformance-no-build: RANDOM := $(shell bash -c 'echo $$RANDOM')
 run-sdk-conformance-no-build: DELAY ?= $(shell bash -c "echo $$[ ($(RANDOM) % 5 ) + 1 ]")
 run-sdk-conformance-no-build: TESTS ?= ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve
 run-sdk-conformance-no-build: PORT ?= 59357


If the other one is HTTP_PORT then this one should be GRPC_PORT.

roberthbailey · 2019-10-08T03:32:39Z

test/sdk/restapi/http-api-test.go.nolint

+		if err != nil {
+			log.Fatalf("Error in WatchGameServer: %v\n", err)
+		}
+		uid = gs.ObjectMeta.Uid


https://github.com/googleforgames/agones/blob/master/test/sdk/go/sdk-client-test.go sets the uid through a channel, which seems more thread safe.

Used channel as in Go SDK test.

test/sdk/restapi/http-api-test.go.nolint

roberthbailey · 2019-10-08T03:36:28Z

test/sdk/restapi/http-api-test.go.nolint

+	go func() {
+		gs, _, err := cli.SDKApi.WatchGameServer(ctx)
+		if err != nil {
+			log.Fatalf("Error in WatchGameServer: %v\n", err)


I think log.Fatal should only happen in the main goroutine. Can this pass the error back to the main goroutine instead of a uid to signal that it failed?

roberthbailey · 2019-10-08T03:37:50Z

test/sdk/restapi/http-api-test.go.nolint

+		log.Fatalf("Could not SetLabel: %v\n", err)
+	}
+
+	time.Sleep(3 * time.Second)


there isn't a sleep between the other api calls, why one here?

Maybe this wouldn't be necessary if you used a channel to pass back the uid (which would block).

Yes, I removed this sleep

roberthbailey · 2019-10-08T03:38:28Z

test/sdk/restapi/http-api-test.go.nolint

+	if err != nil {
+		log.Fatalf("Could not SetAnnotation: %v\n", err)
+	}
+	time.Sleep(1 * time.Second)


why a sleep here?

It is redundant, removed

build/includes/sdk.mk

aLekSer · 2019-10-08T12:37:46Z

Can you explain why http-api-test.go.nolint can't pass the linter?

First of all if we add this Go file we should also add multiple files generated by Swagger. This full import:
agones.dev/agones/test/sdk/restapi/swagger
Second is that Swagger resulted auto-generated code does not pass the linter itself. It does not have comments prior to every exported function.
If it is ok to include swagger results and manually correct all linter issues in resulting code I could attach these files to this PR.

aLekSer · 2019-10-08T12:43:24Z

Overall there is 69 errors in swagger generated code. Example of linting errors can be found here:

test/sdk/restapi/swagger/client.go:111:6: `typeCheckParameter` is unused (deadcode)
test/sdk/restapi/swagger/client.go:125:6: `parameterToString` is unused (deadcode)
test/sdk/restapi/swagger/client.go:335:6: `reportError` is unused (deadcode)
test/sdk/restapi/swagger/client.go:440:6: `strlen` is unused (deadcode)
test/sdk/restapi/swagger/api_sdk.go:209: 209-467 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:298-556` (dupl)
test/sdk/restapi/swagger/api_sdk.go:298: 298-556 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:387-645` (dupl)
test/sdk/restapi/swagger/api_sdk.go:387: 387-645 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:476-734` (dupl)
test/sdk/restapi/swagger/api_sdk.go:476: 476-734 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:209-467` (dupl)
test/sdk/restapi/swagger/api_sdk.go:34: 34-200 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:654-820` (dupl)
test/sdk/restapi/swagger/api_sdk.go:654: 654-820 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:34-200` (dupl)
test/sdk/restapi/swagger/api_sdk.go:565: 565-645 lines are duplicate of `test/sdk/restapi/swagger/api_sdk.go:654-734` (dupl)
test/sdk/restapi/swagger/client.go:425:4: ineffectual assignment to `expires` (ineffassign)

aLekSer · 2019-10-08T13:12:49Z

There is one more issue with Swagger or sdk.swagger.json definition file, it generates wrong function for WatchGameServer which waits forever until the end of test, however it should receive and somehow output granular GameServer results, not wait till EOF.
Debugging this issue now.

Need to find a way to change ioutil.ReadAll() which is used in swagger into something which reads only one JSON from Body.

aLekSer · 2019-10-08T14:19:25Z

One more difference in that we receive "result" key while in swagger we expect to receive nested GS fields straight away :

 {"result":{"object_meta":{"name":"local","namespace":"default","uid":"3260771541929705927","resource_version":"v1","generation":"1","creation_timestamp":"1570544129","annotations":{"annotation":"true"},"labels":{"agones.dev/sdk-creationTimestamp":"1570544129","islocal":"true"}},"status":{"state":"Allocated","address":"127.0.0.1","ports":[{"name":"default","port":7777}]}}}

aLekSer · 2019-10-08T14:25:49Z

When I added new Result struct:

// A GameServer Custom Resource Definition object We will only export those resources that make the most sense. Can always expand to more as needed.
type SdkGameServer struct {
	ObjectMeta *GameServerObjectMeta `json:"object_meta,omitempty"`
	Spec *GameServerSpec `json:"spec,omitempty"`
	Status *GameServerStatus `json:"status,omitempty"`
}

type Result struct {
	Result SdkGameServer `json:"result,omitempty"`
}

And switched from ioutil.ReadAll(body) into bufio.ReadSlice(byte('\n')) test become successful.

This leads us to the need of changing sdk.swagger.json file.

aLekSer · 2019-10-10T12:06:27Z

I have updated this PR and include a TODO which could be removed when Swagger json would be updated.
I was not able to get rid of clean step for this test.
Other than that this PR is good to go.

agones-bot · 2019-10-10T12:17:10Z

Build Succeeded 👏

Build Id: ca6e68c5-50bb-4193-8c55-8f81c4a70d4c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-e12e769
image: gcr.io/agones-images/agones-sdk:1.1.0-e12e769
image: gcr.io/agones-images/agones-ping:1.1.0-e12e769
Linux C++ SDK (build): agonessdk-1.1.0-e12e769-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-e12e769.zip

A preview of the website (the last 30 builds are retained):

https://e12e769-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e12e769

agones-bot · 2019-10-10T12:19:54Z

Build Succeeded 👏

Build Id: 0b679df4-5b94-49f9-bee8-a3dc2a20ac97

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-527739f
image: gcr.io/agones-images/agones-sdk:1.1.0-527739f
image: gcr.io/agones-images/agones-ping:1.1.0-527739f
Linux C++ SDK (build): agonessdk-1.1.0-527739f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-527739f.zip

A preview of the website (the last 30 builds are retained):

https://527739f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-527739f

agones-bot · 2019-10-10T12:32:35Z

Build Succeeded 👏

Build Id: 369f9a53-b67b-49df-8131-6fb59216e087

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-7cf1838
image: gcr.io/agones-images/agones-sdk:1.1.0-7cf1838
image: gcr.io/agones-images/agones-ping:1.1.0-7cf1838
Linux C++ SDK (build): agonessdk-1.1.0-7cf1838-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-7cf1838.zip

A preview of the website (the last 30 builds are retained):

https://7cf1838-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7cf1838

agones-bot · 2019-10-14T16:49:24Z

Build Succeeded 👏

Build Id: 558a9eb3-7331-429f-8fb4-9e7f79fc4716

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-b24ec55
image: gcr.io/agones-images/agones-sdk:1.1.0-b24ec55
image: gcr.io/agones-images/agones-ping:1.1.0-b24ec55
Linux C++ SDK (build): agonessdk-1.1.0-b24ec55-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-b24ec55.zip

A preview of the website (the last 30 builds are retained):

https://b24ec55-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b24ec55

agones-bot · 2019-10-14T19:42:43Z

Build Succeeded 👏

Build Id: 13b04f2e-77e6-4354-81c0-38ab1ba3bad2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-5f3c1d7
image: gcr.io/agones-images/agones-sdk:1.1.0-5f3c1d7
image: gcr.io/agones-images/agones-ping:1.1.0-5f3c1d7
Linux C++ SDK (build): agonessdk-1.1.0-5f3c1d7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-5f3c1d7.zip

A preview of the website (the last 30 builds are retained):

https://5f3c1d7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-5f3c1d7

roberthbailey · 2019-10-14T19:59:04Z

test/sdk/restapi/http-api-test.go.nolint

+
+func main() {
+	log.Println("Client is starting")
+	time.Sleep(1 * time.Second)


Is this sleep necessary? The waiting loop below should take care of startup timing differences between the test and the sdkserver.

build/includes/sdk.mk

roberthbailey · 2019-10-14T19:59:57Z

test/sdk/restapi/http-api-test.go.nolint

+
+	ctx := context.Background()
+
+	// Wait for SDK server to start (5 seconds)


Change 5 -> 30 to be consistent with the SDKs?

roberthbailey · 2019-10-14T20:03:42Z

test/sdk/restapi/http-api-test.go.nolint

+
+	once := true
+	go func() {
+		gs, _, err := cli.SDKApi.WatchGameServer(ctx)


This looks like it only fires once. I see two ramifications:

If the first time fails for some reason the test will fail. Should it be in a loop?

The error flow shouldn't be indented

I will look closely at your suggestions tomorrow.
WatchGameServer() would not succeed currently, as it wait for closing the connection not line termination symbol (tracked here #1106 ). So I left this lines as is and they would actually work, when Swagger spec and generator would be fixed.

roberthbailey · 2019-10-14T20:04:47Z

test/sdk/restapi/http-api-test.go.nolint

+		gs, _, err := cli.SDKApi.WatchGameServer(ctx)
+		log.Printf("Watch response: %+v", gs)
+		if err != nil {
+			log.Printf("Error in WatchGameServer: %v\n", err)


return (or continue if in a loop) here to keep the rest of the control flow further left.

roberthbailey · 2019-10-14T20:09:02Z

test/sdk/restapi/http-api-test.go.nolint

+		log.Fatalf("Could not SetLabel: %v\n", err)
+	}
+
+	// TODO: fix WatchGameServer() HTTP API Swagger definition and remove the following lines


The go routine above writes to c as does this one. Can we delete this TODO and the below go routine? Or does the watch never fire?

The watch function does not return, mentioned this in above comment, it is waiting for EOF, and "result". Opened a ticket for that.

agones-bot · 2019-10-15T20:03:34Z

Build Succeeded 👏

Build Id: 0c43ac6a-a7a4-4501-bcda-0e57f9edea27

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-774c80d
image: gcr.io/agones-images/agones-sdk:1.1.0-774c80d
image: gcr.io/agones-images/agones-ping:1.1.0-774c80d
Linux C++ SDK (build): agonessdk-1.1.0-774c80d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-774c80d.zip

A preview of the website (the last 30 builds are retained):

https://774c80d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-774c80d

roberthbailey · 2019-10-18T19:09:57Z

This PR now has a conflicting file.

agones-bot · 2019-10-18T20:48:44Z

Build Succeeded 👏

Build Id: 36f5a30b-a163-407e-a9c6-69a79692ba7a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-a8d1b39
image: gcr.io/agones-images/agones-sdk:1.1.0-a8d1b39
image: gcr.io/agones-images/agones-ping:1.1.0-a8d1b39
Linux C++ SDK (build): agonessdk-1.1.0-a8d1b39-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-a8d1b39.zip

A preview of the website (the last 30 builds are retained):

https://a8d1b39-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-a8d1b39

Add conformance test for Rest API SDK server port 59358. Does not contain swagger pregenerated files. Switched Go file to other file extension, because it is not possible to exclude one file from GolangCI linter run.

agones-bot · 2019-10-19T12:50:01Z

Build Succeeded 👏

Build Id: 89301d9a-070b-447c-b22b-397d6d53ead1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-b4a0b13
image: gcr.io/agones-images/agones-sdk:1.1.0-b4a0b13
image: gcr.io/agones-images/agones-ping:1.1.0-b4a0b13
Linux C++ SDK (build): agonessdk-1.1.0-b4a0b13-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-b4a0b13.zip

A preview of the website (the last 30 builds are retained):

https://b4a0b13-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b4a0b13

google-oss-robot · 2019-10-20T06:32:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-10-20T07:08:10Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-10-20T07:42:27Z

Build Succeeded 👏

Build Id: a55efbe6-2f81-4b17-aba6-41adbf7587bf

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3ee43ce
image: gcr.io/agones-images/agones-sdk:1.1.0-3ee43ce
image: gcr.io/agones-images/agones-ping:1.1.0-3ee43ce
Linux C++ SDK (build): agonessdk-1.1.0-3ee43ce-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3ee43ce.zip

A preview of the website (the last 30 builds are retained):

https://3ee43ce-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1079/head:pr_1079 && git checkout pr_1079
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3ee43ce

google-oss-robot added the do-not-merge/work-in-progress label Sep 26, 2019

google-oss-robot requested review from dzlier-gcp and joeholley September 26, 2019 14:34

google-oss-robot added the size/L label Sep 26, 2019

aLekSer force-pushed the feature/sdk-server-rest-test branch from 05c73cd to 9676408 Compare September 26, 2019 15:05

aLekSer force-pushed the feature/sdk-server-rest-test branch from 9676408 to fc0d9ae Compare September 27, 2019 11:26

aLekSer force-pushed the feature/sdk-server-rest-test branch from fc0d9ae to feb78e3 Compare September 27, 2019 12:15

aLekSer mentioned this pull request Oct 7, 2019

Use non-ephemeral port for Go SDK conformance test #1095

Merged

aLekSer marked this pull request as ready for review October 7, 2019 17:33

google-oss-robot removed the do-not-merge/work-in-progress label Oct 7, 2019

aLekSer force-pushed the feature/sdk-server-rest-test branch from feb78e3 to dbdb640 Compare October 7, 2019 17:34

google-oss-robot assigned roberthbailey Oct 7, 2019

aLekSer force-pushed the feature/sdk-server-rest-test branch from dbdb640 to de1259a Compare October 7, 2019 18:14

aLekSer force-pushed the feature/sdk-server-rest-test branch from de1259a to bb0d420 Compare October 7, 2019 21:21

roberthbailey reviewed Oct 8, 2019

View reviewed changes

aLekSer force-pushed the feature/sdk-server-rest-test branch from 7cf1838 to b24ec55 Compare October 14, 2019 16:21

aLekSer force-pushed the feature/sdk-server-rest-test branch from b24ec55 to 5f3c1d7 Compare October 14, 2019 19:13

roberthbailey reviewed Oct 14, 2019

View reviewed changes

aLekSer force-pushed the feature/sdk-server-rest-test branch from 5f3c1d7 to 774c80d Compare October 15, 2019 19:33

aLekSer force-pushed the feature/sdk-server-rest-test branch from 774c80d to a8d1b39 Compare October 18, 2019 20:15

Add SDK server HTTP API test

b4a0b13

Add conformance test for Rest API SDK server port 59358. Does not contain swagger pregenerated files. Switched Go file to other file extension, because it is not possible to exclude one file from GolangCI linter run.

aLekSer force-pushed the feature/sdk-server-rest-test branch from a8d1b39 to b4a0b13 Compare October 19, 2019 12:15

roberthbailey approved these changes Oct 20, 2019

View reviewed changes

google-oss-robot added the lgtm label Oct 20, 2019

google-oss-robot added the approved label Oct 20, 2019

Merge branch 'master' into feature/sdk-server-rest-test

3ee43ce

google-oss-robot removed the lgtm label Oct 20, 2019

roberthbailey merged commit 971f66f into googleforgames:master Oct 20, 2019

markmandel added this to the 1.1.0 milestone Oct 22, 2019

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones labels Oct 22, 2019

aLekSer mentioned this pull request Oct 25, 2019

Updates GRPC to v1.20.1 #1144

Closed


		ctx := context.Background()

		// Wait for SDK server to start (5 seconds)

Add SDK server HTTP API test #1079

Add SDK server HTTP API test #1079

Conversation

aLekSer commented Sep 26, 2019

aLekSer commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

aLekSer commented Oct 7, 2019

agones-bot commented Oct 7, 2019

agones-bot commented Oct 7, 2019

agones-bot commented Oct 7, 2019

roberthbailey commented Oct 8, 2019

roberthbailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aLekSer commented Oct 8, 2019 • edited Loading

aLekSer commented Oct 8, 2019 • edited Loading

aLekSer commented Oct 8, 2019 • edited Loading

aLekSer commented Oct 8, 2019

aLekSer commented Oct 8, 2019 • edited Loading

aLekSer commented Oct 10, 2019

agones-bot commented Oct 10, 2019

agones-bot commented Oct 10, 2019

agones-bot commented Oct 10, 2019

agones-bot commented Oct 14, 2019

agones-bot commented Oct 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Oct 15, 2019

roberthbailey commented Oct 18, 2019

agones-bot commented Oct 18, 2019

agones-bot commented Oct 19, 2019

google-oss-robot commented Oct 20, 2019

google-oss-robot commented Oct 20, 2019

agones-bot commented Oct 20, 2019

aLekSer commented Oct 8, 2019 •

edited

Loading

aLekSer commented Oct 8, 2019 •

edited

Loading

aLekSer commented Oct 8, 2019 •

edited

Loading

aLekSer commented Oct 8, 2019 •

edited

Loading