Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the log output when starting the grpc gateway in the sdkserver #1096

Merged

Conversation

roberthbailey
Copy link
Member

So that it is clear what port is being bound for http requests.

Very minor fix, but this has been confusing for me for the last couple of days.

so that it is clear what port is being bound for http requests.
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 3, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 3, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 212bf991-b736-44a0-958b-eaa918d4ef1e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1096/head:pr_1096 && git checkout pr_1096
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-63a4df1

@roberthbailey roberthbailey merged commit a86a4b1 into googleforgames:master Oct 3, 2019
@roberthbailey roberthbailey deleted the grpc-gateway-logging branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants